Closed sick-trigger closed 6 years ago
Can confirm. Non-random predefined basements are unaffected.
Side note: anthills exhibit that old weird visual distortion every time the menu cursor is moved near.
Could be possibly related to #22714 or #22723.
Update: Bisecting blaims [410bfdf0ac06fa9ba3b4ae4fa6258e9a0980fca8] Fix town buildings.
Pinging @codemime about #22723.
I've tested a bit:
It is possible to generated house with basement without any issues using place overmap special
command from debug menu.
Setting of high values for houses with basement and low values for houses without basement effectively removes almost all of the houses from the map (houses with basements are not generated, houses without basements are very rare).
"houses": {
"house_two_story_basement": 1000,
"house": 10,
"house_base": 1000
}
rock
, empty_rock
or open_air
terrains toland
overmap location does not help.{
"type": "overmap_location",
"id": "land",
"mode": "allow",
"terrains": [ "forest", "forest_thick", "forest_water", "field", "empty_rock", "open_air", "rock" ]
},
overmap_specials::get_default_batch
returns no house_base
or house_two_story_basement
because they miss occurrences
node.
22:25:22.270 INFO : overmap_specials::get_default_batch: house_base
22:25:22.270 INFO : : skipped empty locations
22:25:22.270 INFO : overmap_specials::get_default_batch: house_two_story_basement
22:25:22.270 INFO : : skipped empty locations
22:25:22.270 INFO : overmap_specials::get_default_batch: Crater
22:25:22.270 INFO : overmap_specials::get_default_batch: Lake
22:25:22.270 INFO : overmap_specials::get_default_batch: Hotel
22:25:22.270 INFO : overmap_specials::get_default_batch: Motel
22:25:22.270 INFO : overmap_specials::get_default_batch: farm_abandoned
22:25:22.270 INFO : overmap_specials::get_default_batch: Shipwreck
22:25:22.270 INFO : overmap_specials::get_default_batch: LMOE Shelter
22:25:22.270 INFO : overmap_specials::get_default_batch: Sewage Treatment Plant
22:25:22.270 INFO : overmap_specials::get_default_batch: Bee Hive
22:25:22.270 INFO : overmap_specials::get_default_batch: Rural Gas Station
22:25:22.270 INFO : overmap_specials::get_default_batch: Gas Station
22:25:22.270 INFO : overmap_specials::get_default_batch: Cabin
22:25:22.270 INFO : overmap_specials::get_default_batch: Strange Cabin
22:25:22.270 INFO : overmap_specials::get_default_batch: Sugar House
22:25:22.270 INFO : overmap_specials::get_default_batch: Farm
22:25:22.270 INFO : overmap_specials::get_default_batch: Strangle Temple
22:25:22.270 INFO : overmap_specials::get_default_batch: Standing stones
22:25:22.270 INFO : overmap_specials::get_default_batch: Lab
22:25:22.270 INFO : overmap_specials::get_default_batch: Ice Lab
22:25:22.270 INFO : overmap_specials::get_default_batch: FEMA Camp
22:25:22.270 INFO : overmap_specials::get_default_batch: Military Bunker
22:25:22.270 INFO : overmap_specials::get_default_batch: Military Outpost
22:25:22.270 INFO : overmap_specials::get_default_batch: Missile Silo
22:25:22.270 INFO : overmap_specials::get_default_batch: Radio Tower
22:25:22.271 INFO : overmap_specials::get_default_batch: Mansion_Road
22:25:22.271 INFO : overmap_specials::get_default_batch: Mansion_Wild
22:25:22.271 INFO : overmap_specials::get_default_batch: Megastore
22:25:22.271 INFO : overmap_specials::get_default_batch: Hospital
22:25:22.271 INFO : overmap_specials::get_default_batch: Public Works
22:25:22.271 INFO : overmap_specials::get_default_batch: Apartments_Con
22:25:22.271 INFO : overmap_specials::get_default_batch: Apartments_Mod
22:25:22.271 INFO : overmap_specials::get_default_batch: Office Tower
22:25:22.271 INFO : overmap_specials::get_default_batch: Office_Tower_2.0
22:25:22.271 INFO : overmap_specials::get_default_batch: Cathedral
22:25:22.271 INFO : overmap_specials::get_default_batch: School
22:25:22.271 INFO : overmap_specials::get_default_batch: Prison
22:25:22.271 INFO : overmap_specials::get_default_batch: Mine Entrace
22:25:22.271 INFO : overmap_specials::get_default_batch: Anthill
22:25:22.271 INFO : overmap_specials::get_default_batch: Spider Pit
22:25:22.271 INFO : overmap_specials::get_default_batch: Slime Pit
22:25:22.271 INFO : overmap_specials::get_default_batch: Fungal Bloom
22:25:22.271 INFO : overmap_specials::get_default_batch: Fungal Tower
22:25:22.271 INFO : overmap_specials::get_default_batch: Fungal Flowers
22:25:22.271 INFO : overmap_specials::get_default_batch: Triffid Grove
22:25:22.271 INFO : overmap_specials::get_default_batch: Evac Shelter
22:25:22.271 INFO : overmap_specials::get_default_batch: Cave
22:25:22.271 INFO : overmap_specials::get_default_batch: Toxic Waste Dump
22:25:22.271 INFO : overmap_specials::get_default_batch: Hazardous Waste Sarcophagus
22:25:22.271 INFO : overmap_specials::get_default_batch: Mall
22:25:22.271 INFO : overmap_specials::get_default_batch: Necropolis
22:25:22.271 INFO : overmap_specials::get_default_batch: evac_center
22:25:22.271 INFO : overmap_specials::get_default_batch: bandit_cabin
22:25:22.271 INFO : overmap_specials::get_default_batch: bandit_camp
22:25:22.271 INFO : overmap_specials::get_default_batch: sai
22:25:22.271 INFO : overmap_specials::get_default_batch: power_station_small
22:25:22.271 INFO : overmap_specials::get_default_batch: power_station_large
22:25:22.271 INFO : overmap_specials::get_default_batch: warehouse
22:25:22.271 INFO : overmap_specials::get_default_batch: Home Improvement Superstore
22:25:22.271 INFO : overmap_specials::get_default_batch: ranch_camp
22:25:22.271 INFO : overmap_specials::get_default_batch: football_field
22:25:22.271 INFO : overmap_specials::get_default_batch: campsite
22:25:22.272 INFO : overmap_specials::get_default_batch: campsite_cabin_incomplete
22:25:22.272 INFO : overmap_specials::get_default_batch: campsite_field_biker
22:25:22.272 INFO : overmap_specials::get_default_batch: campsite_a
22:25:22.272 INFO : overmap_specials::get_default_batch: campsite_field_biker_destroyed
22:25:22.272 INFO : overmap_specials::get_default_batch: rest_stop
22:25:22.272 INFO : overmap_specials::get_default_batch: roadstop_a
22:25:22.272 INFO : overmap_specials::get_default_batch: roadstop_b
22:25:22.272 INFO : overmap_specials::get_default_batch: pump_station
22:25:22.272 INFO : overmap_specials::get_default_batch: garage_gas
22:25:22.272 INFO : overmap_specials::get_default_batch: cemetery_religious
22:25:22.272 INFO : overmap_specials::get_default_batch: Pond
22:25:22.272 INFO : overmap_specials::get_default_batch: basin
22:25:22.272 INFO : overmap_specials::get_default_batch: bog
22:25:22.272 INFO : overmap_specials::get_default_batch: Swamp Shack
22:25:22.272 INFO : overmap_specials::get_default_batch: apple_orchard
22:25:22.272 INFO : overmap_specials::get_default_batch: Dairy Farm
22:25:22.272 INFO : overmap_specials::get_default_batch: State Park
22:25:22.272 INFO : overmap_specials::get_default_batch: Fishing Pond
22:25:22.272 INFO : overmap_specials::get_default_batch: Derelict Property
22:25:22.272 INFO : overmap_specials::get_default_batch: Hunting Blind
22:25:22.272 INFO : overmap_specials::get_default_batch: Mansion2_Road
22:25:22.272 INFO : overmap_specials::get_default_batch: Mansion2_Road_Alt
22:25:22.272 INFO : overmap_specials::get_default_batch: Mansion2_Wild
22:25:22.272 INFO : overmap_specials::get_default_batch: Mansion2_WildAlt
22:25:22.272 INFO : overmap_specials::get_default_batch: Lumberyard
22:25:22.272 INFO : overmap_specials::get_default_batch: FakeSpecial_house
22:25:22.272 INFO : : skipped empty occurrences
22:25:22.272 INFO : overmap_specials::get_default_batch: FakeSpecial_abstorefront
22:25:22.272 INFO : : skipped empty occurrences
22:25:22.272 INFO : overmap_specials::get_default_batch: FakeSpecial_art_gallery
22:25:22.272 INFO : : skipped empty occurrences
22:25:22.272 INFO : overmap_specials::get_default_batch: FakeSpecial_bakery
22:25:22.272 INFO : : skipped empty occurrences
22:25:22.272 INFO : overmap_specials::get_default_batch: FakeSpecial_bank
22:25:22.272 INFO : : skipped empty occurrences
22:25:22.272 INFO : overmap_specials::get_default_batch: FakeSpecial_bar
22:25:22.272 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_bowling_alley
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_candy_shop
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_church
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_construction_site
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_dispensary
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_dojo
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_fire_station
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_furniture
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_gym
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_gym_fitness
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_home_improvement
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_icecream_shop
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_mil_surplus
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_mortuary
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_museum
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_office_cubical
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_office_doctor
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_orchard
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.273 INFO : overmap_specials::get_default_batch: FakeSpecial_pawn
22:25:22.273 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_police
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_post_office
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_antique
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_arcade
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_bike_shop
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_bookstore
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_butcher
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_clothes
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_electronics
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_garage
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_gardening
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_gas
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_grocery
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_gun
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_hardware
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_jewelry
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_laundromat
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_library
22:25:22.274 INFO : : skipped empty occurrences
22:25:22.274 INFO : overmap_specials::get_default_batch: FakeSpecial_s_liquor
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_s_lot
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_s_music
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_s_pharm
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_s_pizza_parlor
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_s_restaurant
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_s_restaurant_coffee
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_s_restaurant_fast
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_s_sports
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_s_teashop
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_small_office
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_small_storage_units
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_station_radio
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_sub_station
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_veterinarian
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_cemetery_small
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_park
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_pavilion
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.275 INFO : overmap_specials::get_default_batch: FakeSpecial_pool
22:25:22.275 INFO : : skipped empty occurrences
22:25:22.276 INFO : overmap_specials::get_default_batch: FakeSpecial_skate_park
22:25:22.276 INFO : : skipped empty occurrences
22:25:22.276 INFO : overmap_specials::get_default_batch: FakeSpecial_small_wooded_trail
22:25:22.276 INFO : : skipped empty occurrences
22:25:22.276 INFO : overmap_specials::get_default_batch: FakeSpecial_s_restaurant_deserted_test
22:25:22.276 INFO : : skipped empty occurrences````
overmap::place_building
tries to place house building, but fails each try. For example:22:31:46.246 INFO : overmap::place_building: Trying to place [house_two_story_basement] at [X:43, Y: 52, Z: 0] in town: [Nottingham]. Retries left: [10]
22:31:46.246 INFO : overmap::place_building: Trying to place [house_two_story_basement] at [X:43, Y: 52, Z: 0] in town: [Nottingham]. Retries left: [9]
22:31:46.246 INFO : overmap::place_building: Trying to place [house_two_story_basement] at [X:43, Y: 52, Z: 0] in town: [Nottingham]. Retries left: [8]
22:31:46.246 INFO : overmap::place_building: Trying to place [house_base] at [X:43, Y: 52, Z: 0] in town: [Nottingham]. Retries left: [7]
22:31:46.246 INFO : overmap::place_building: Trying to place [house_base] at [X:43, Y: 52, Z: 0] in town: [Nottingham]. Retries left: [6]
22:31:46.246 INFO : overmap::place_building: Trying to place [house_base] at [X:43, Y: 52, Z: 0] in town: [Nottingham]. Retries left: [5]
22:31:46.246 INFO : overmap::place_building: Trying to place [house_base] at [X:43, Y: 52, Z: 0] in town: [Nottingham]. Retries left: [4]
22:31:46.246 INFO : overmap::place_building: Trying to place [house_two_story_basement] at [X:43, Y: 52, Z: 0] in town: [Nottingham]. Retries left: [3]
22:31:46.246 INFO : overmap::place_building: Trying to place [house_two_story_basement] at [X:43, Y: 52, Z: 0] in town: [Nottingham]. Retries left: [2]
22:31:46.246 INFO : overmap::place_building: Trying to place [house_two_story_basement] at [X:43, Y: 52, Z: 0] in town: [Nottingham]. Retries left: [1]
overmap::place_building
cannot place house_two_story_basement
and house_base
on field
terrain:22:54:17.656 INFO : overmap::place_building: Trying to place [house_two_story_basement] at [X:41, Y: 144, Z: 0] in town: [Kent]. Retries left: [10]
22:54:17.656 INFO : overmap::can_place_special: Checking if it is possible to place [house_two_story_basement] at [X:41, Y: 143, Z: 0].
22:54:17.656 INFO : special.can_be_placed_on( tid ): [field] is [0]
22:54:17.656 INFO : overmap::place_building: Trying to place [house_two_story_basement] at [X:41, Y: 144, Z: 0] in town: [Kent]. Retries left: [9]
22:54:17.656 INFO : overmap::can_place_special: Checking if it is possible to place [house_two_story_basement] at [X:41, Y: 143, Z: 0].
22:54:17.656 INFO : special.can_be_placed_on( tid ): [field] is [0]
22:54:17.656 INFO : overmap::place_building: Trying to place [house_base] at [X:41, Y: 144, Z: 0] in town: [Kent]. Retries left: [8]
22:54:17.656 INFO : overmap::can_place_special: Checking if it is possible to place [house_base] at [X:41, Y: 143, Z: 0].
22:54:17.656 INFO : special.can_be_placed_on( tid ): [field] is [0]
22:54:17.656 INFO : overmap::place_building: Trying to place [house_two_story_basement] at [X:41, Y: 144, Z: 0] in town: [Kent]. Retries left: [7]
22:54:17.656 INFO : overmap::can_place_special: Checking if it is possible to place [house_two_story_basement] at [X:41, Y: 143, Z: 0].
22:54:17.656 INFO : special.can_be_placed_on( tid ): [field] is [0]
22:54:17.656 INFO : overmap::place_building: Trying to place [house_two_story_basement] at [X:41, Y: 144, Z: 0] in town: [Kent]. Retries left: [6]
22:54:17.656 INFO : overmap::can_place_special: Checking if it is possible to place [house_two_story_basement] at [X:41, Y: 143, Z: 0].
22:54:17.656 INFO : special.can_be_placed_on( tid ): [field] is [0]
22:54:17.656 INFO : overmap::place_building: Trying to place [house_base] at [X:41, Y: 144, Z: 0] in town: [Kent]. Retries left: [5]
22:54:17.656 INFO : overmap::can_place_special: Checking if it is possible to place [house_base] at [X:41, Y: 143, Z: 0].
22:54:17.656 INFO : special.can_be_placed_on( tid ): [field] is [0]
22:54:17.656 INFO : overmap::place_building: Trying to place [house_base] at [X:41, Y: 144, Z: 0] in town: [Kent]. Retries left: [4]
22:54:17.656 INFO : overmap::can_place_special: Checking if it is possible to place [house_base] at [X:41, Y: 143, Z: 0].
22:54:17.656 INFO : special.can_be_placed_on( tid ): [field] is [0]
22:54:17.656 INFO : overmap::place_building: Trying to place [house_base] at [X:41, Y: 144, Z: 0] in town: [Kent]. Retries left: [3]
22:54:17.656 INFO : overmap::can_place_special: Checking if it is possible to place [house_base] at [X:41, Y: 143, Z: 0].
22:54:17.656 INFO : special.can_be_placed_on( tid ): [field] is [0]
22:54:17.656 INFO : overmap::place_building: Trying to place [house_two_story_basement] at [X:41, Y: 144, Z: 0] in town: [Kent]. Retries left: [2]
22:54:17.656 INFO : overmap::can_place_special: Checking if it is possible to place [house_two_story_basement] at [X:41, Y: 143, Z: 0].
22:54:17.656 INFO : special.can_be_placed_on( tid ): [field] is [0]
22:54:17.656 INFO : overmap::place_building: Trying to place [house_two_story_basement] at [X:41, Y: 144, Z: 0] in town: [Kent]. Retries left: [1]
22:54:17.656 INFO : overmap::can_place_special: Checking if it is possible to place [house_two_story_basement] at [X:41, Y: 143, Z: 0].
22:54:17.656 INFO : special.can_be_placed_on( tid ): [field] is [0]
While fix is not merged you can try to replace \data\json\multitile_city_buildings.json
with this file: https://raw.githubusercontent.com/ZhilkinSerg/Cataclysm-DDA/0287eefb2cf998e6a0dcd322b893488feda13e3f/data/json/multitile_city_buildings.json.
Sorry for introducing the bug and thanks to @ZhilkinSerg for the investigation.
Side note: anthills exhibit that old weird visual distortion every time the menu cursor is moved near.
I confirm this, but this is unrelated bug as far as I can see.
Game version: latest experimental
Operating system: windows
Tiles or curses: both
Mods active: default
Expected behavior
houses will occasionally have basements
Actual behavior
they dont
Steps to reproduce the behavior
make default world, debug reveal map and look under cities for basements. there are none.