#22747 rendered tank guns unusuable, other manual guns no longer manual

smolbird commented 6 years ago

Game version: 0.C-27251-gef69f3b

Operating system: Windows 10

Tiles or curses: Curses (used for quicker testing of latest available version)

Mods active: "dda", "filthy_morale", "no_npc_food", "novitamins", "blazemod", "Tanks", "More_Survival_Tools"

Expected behavior

Manually firing a tank's main gun is possible, as original behavior.
Using examine on a tank's main gun allows reloading or unloading it.
The mounted M240 and M2 Browning act as manual-only weapons, as before.

Actual behavior

Attempting to hit f while unarmed fails to accomplish anything.
Trying to examine the main gun skips to showing vehicle menu, cargo contents of seat/tile, etc.
The M240 and M2 Browning can be configured to fire as unmanned weapons.

Steps to reproduce the behavior

Debug in a main battle tank.
Attempt to load and/or fire the main gun.

Additional Information

The mounted M240 and M2 Browning are still functional, but no longer behave as though manual. why these are broken in one way yet the tank weapons are broken in another is utterly baffling to me.

Pinging @Night-Pryanik due to this being their concern.

ZhilkinSerg commented 6 years ago

Would you please elaborate on M240 and M2?

Firing mode can be changed by s key both before and after change:

default

smolbird commented 6 years ago

As in, being able to order them to fire from the vehicle controls menu despite intended use of the MANUAL flag. If that predates the PR then it's a separate older bug, but it does bear mentioning for the sake of deciphering the cause.

ZhilkinSerg commented 6 years ago

Can you please unzip attached file to folder \data\mods\Tanks\items.json replacing original file and test in fresh world if tank main guns started to work?

items.zip

ZhilkinSerg commented 6 years ago

So, I guess "copy_from" is not working in mods.

smolbird commented 6 years ago

Tested, nothing different.

smolbird commented 6 years ago

Odd. Any other possible causes?

ZhilkinSerg commented 6 years ago

Tested, nothing different.

Yes, it seems there is one more file required - please also unzip attached file to folder \data\mods\Tanks\parts.json replacing original file.

parts.zip

smolbird commented 6 years ago

Oh right. Doh.

smolbird commented 6 years ago

Tested, it seems to work. Just leaves the pre-exisiting oddities it seems, but that's a subject for another issue.

CleverRaven / Cataclysm-DDA