search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.65k stars 4.18k forks source link

Spider poison ignored armor #23681

Closed FulcrumA closed 5 years ago

FulcrumA commented 6 years ago

Game version:0.C-27732

Operating system: Windows 7

Tiles or curses: Tiles

Mods active: More Survival Tools, No Explosive Zombies, No Fungal Monsters, StatsThroughSkill IV, Vehicle Additions Pack, Tanks and Other Vehicles, Bionics Systems Mod, Boats, Icecoon's Arsenal, Filthy Clothing, Makeshift Items Mod, More Buildings, No Flaming Weapons, Disable Mutagens, Disable NPC Needs, No Antique Firearms, No Fictional Guns, NPC Traits

Expected behavior

Spiders, when attacking and biting the character, attempt to inject poison on first bite and then only every so often and it's counted as such only if they can penetrate armor and cause direct damage with the bite.

Actual behavior

Spiders, at least of the basement-dwelling variety seem to be injecting poison with every attack with said poison accumulating even when spiders themselves have hard time penetrating the armor. Which leads to silly situations where character is pain-locked while still alive: ouch I think zombies' bites work much better, maybe their code could be somehow repurposed?

Steps to reproduce the behavior

Attack spiders when armored but not poison-resistant.

Night-Pryanik commented 6 years ago

Closed by #23764.

FulcrumA commented 6 years ago

@Night-Pryanik I am checking referenced fix and since it had issues, it was reverted quite a few days ago, as reported in ticket itself. Does it mean that this bug was fixed elsewhere?

Night-Pryanik commented 6 years ago

Oh, sorry, my fault.

Night-Pryanik commented 5 years ago

I guess think issue could be closed. The code explicitly states that monsters can apply their on-hit effects only if their attack dealt any damage. Thus spiders that fail to penetrate armor can't poison the player. If the player is poisoned then it's his armor to blame (low values of coverage and/or protection).

FulcrumA commented 5 years ago

Was it something that happened since the ticket was made? If it's fixed, it's fixed. I worry though that a player can still be stunlocked despite neglible damage with enemies unable to really kill said player without forcing a long wait. We can always try to trim the issue list for now and have it closed and if this thing happens again to me or someone else, we can bother you to reopen it, I guess?

Night-Pryanik commented 5 years ago

I worry though that a player can still be stunlocked despite neglible damage with enemies unable to really kill said player

That's a balance issue, @jesseclvrt mentioned it in #23764 - maybe we need to increase the minimum damage dealt threshold for poison to be applied, but the issue you raised - "Poison is applied despite there was no armor penetration" - isn't confirmed.

if this thing happens again to me or someone else, we can bother you to reopen it, I guess?

Yes, of course.

FulcrumA commented 5 years ago

Alright then, closing it for now.