search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.65k stars 4.18k forks source link

Butchering reports of misleading possible CBM on every corpse. #24876

Closed jim-huynh closed 6 years ago

jim-huynh commented 6 years ago

Version: 0.c-30616-g5d18af2

Every butchering event shows a "Your butcher tool encounter something implanted in this corpse, but your rough cut destroys it." or some variant of a possible CBM regardless of there being a possible CBM.

Since this is the PC doing something, he shouldn't report to himself that there was something implanted when there wasn't. Assuming that the PC completely takes apart a corpse, they would know after the fact that there was, or was not something implanted in the corpse.

If there was indeed a CBM implanted, then a butchering event that destroyed a CBM should yield a destroyed CBM item, and not just bypass it.

FulcrumA commented 6 years ago

Can confirm in bizarre situations such as these: uhoh uhoh On top of that, said coyote provided me with 28 pieces of meat which is quite excessive, at least at lower survival levels without REALLY good butchering tool.

jim-huynh commented 6 years ago

Yeah he multiplied get_meat_chunks() by some rather large numbers, and I don't see anything in the new code that reduces it back to the old yields after processing.

nexusmrsep commented 6 years ago

It's not that its excessive, its just based on weight, and guess what? Coyote as SMALL weights 40 kg, so the yield is a derivative from that. Yeah, that's a monster coyote...

jim-huynh commented 6 years ago

You're right, a 40 kg animal should probably yield around 30-40% of it's weight in meat. At 0.2 kg per meat object, your numbers are closer to expected, but it does change survival balance.

Things like a full sized deer (large) is going to be a jackpot.

nexusmrsep commented 6 years ago

There should be some tweaks for the weight of small animals followed by yields.