Can't refill vehicle with water or clean water

[MonkWho]

When trying to refill vehicle tanks with water or clean water it says "You don't have the necessary item at hand" even if you have containers with said liquid in your inventory or in containers nearby. Refilling with gasoline or diesel works as expected. My vehicle also has a kitchen unit installed. I can drink clean water from it. But if I boil water using the kitchen I can't put new clean water into a vehicle tank (empty or with existing liquid in it). OS: Windows 10 Game Version: 0.C-30616-g5d18af2

To Reproduce:

• Examine the vehicle
• Try to re[f]ill a tank that has clean water in it

Ran the same test in 0.C-30507-g85b8217 (my "previous_version" in the launcher) and it works like a charm with water and clean water.

[MonkWho]

Did some quick checking and it looks like this problem starts in build 7701. If that helps to track the cause.

[Androwski3000]

Can this be solved by installing a water faucet? - I´m just in the INSTALL menu of a RV and you can install external tanks, like a 200 L tank with a steel barrel. In the description text it says, install a water faucet, if you keep water in that tank.

I´ll try it and report. The next water faucet I know of is miles away right now. EDIT: Isn´t working. I was thinking vise versa. A faucet is there to get water out of it, not to fill in.

[MonkWho]

Tested with water faucet as well. Does not work. It feel like some change was made that sees gasoline and diesel as an acceptable fluid to fill vehicle tanks but does not see water or clean water.

[paulenka-aleh]

I guess freezing mechanics. Now ambient temperature makes water active. And active liquids cannot be in vehicle...

[narc0tiq]

I believe this is also the reason I haven't been able to put vinegar and bleach into vehicle tanks. Thanks for tracking it down to the right build!

Here's the diff between b7700 and 7701: https://github.com/CleverRaven/Cataclysm-DDA/compare/90d5bc3f0f251b2265e28ae05340f01c121a65b0...5d18af223b3ace52111585d861524721e32e40dd

...and I figured out why: https://github.com/CleverRaven/Cataclysm-DDA/pull/24228/files#diff-f7ca61cf749eba039da961e8a7be1630R171 -- all comestible items were turned into active items so they'd process temperature...

...however: https://github.com/CleverRaven/Cataclysm-DDA/blob/b8ef478f8998929fc3ab53c9a24ccbbece595cb3/src/game.cpp#L9515-L9516 -- active liquids can't be put into vehicle tanks!

Diesel and gasoline aren't consumable, which explains why they kept working.

[narc0tiq]

ambient temperature makes water active.

Heh, you posted that while I was looking things up, but it's correct (except all comestibles are just always active).

[MonkWho]

So do we need to put an extra flag on non perishable liquids (water, alcohol, bleach, etc) to distinguish them from "those that rot" active ones?

[Night-Pryanik]

Duplicate of #21246.

[MonkWho]

It is a related issue to the duplicate you mentioned but I don't think it's the same issue since I was able to refill the vehicle tanks before build 7701. Water I'm trying to pour into the vehicle is not cold or hot but it's same exact water that is in the vehicle tanks already. In fact I can siphon some water from the vehicle into a bottle but can't pour it back in immediately after.

[narc0tiq]

I was able to refill the vehicle tanks before build 7701.

Yes, because #24228 (among other things) expanded the active items to be all comestibles, regardless of rot-ability, heat, or anything else. It's the same issue, just much harder to mitigate now.

[MonkWho]

@narc0tiq, that makes sense. I guess for now we have to carry non fuel liquids in tanks in storage and not attached to the vehicle eh? Thank you for explaining it. Hope someone figures out how to handle this soon.