CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.26k stars 4.12k forks source link

Lifting/cranes have restrictions, but do not inform players of these in any way #25639

Closed Regularitee closed 6 years ago

Regularitee commented 6 years ago

The current restrictions on cranes are: 1) It must be on a vehicle other than that being worked on 2) It must be within two tiles of the player/vehicle being worked on

It's objectively horrible design that these two restrictions are in place, and that no where in the game does it tell the player this information. The lack of feedback means players will fail again and again, becoming confused and frustrated, since they have no feedback on why it fails to work.

These restrictions should to be told to the player in an in-game manner, or otherwise removed completely.

EDIT: I was incorrect, it is in-game by examining the crane vehicle part. Though it is still missing from vehicle part items, and from providing any error message when examining the vehicle being worked on with the crane.

maniak1349 commented 6 years ago

cata_boom It probably should be mentioned on parts before they are installed too though.

Regularitee commented 6 years ago

My mistake, it was present.

Though it does seem to be poorly placed; it requires you be viewing the vehicle screen of the vehicle with the crane... which is mutually exclusive with seeing the vehicle you are working on (since cranes don't work for the vehicles they are installed on).

Having it on the item description would be ideal, though having it listed under the additional requirements would be much better if possible. i.e.,

Additional requirements: strength 20 OR tool with lifting 4 within 4 tiles

kevingranade commented 6 years ago

Chill out, if you cant be civil, we dont want your bug reports.

mrkybe commented 6 years ago

@Regularitee Cranes should actually work for the vehicles that they are installed on now. The changes in behavior are as a result of fixing that. The crane needs a clear path to the installation site. Looks like the merge didn't go through correctly, since the text that is there is not what I had in the PR. Will fix.

The intended description was:

"A rigid steel boom crane. If it is in your line of sight and within two tiles of another vehicle, you will automatically use it when you want jack up the other vehicle to change the its wheels. To use it to lift a heavy component like an engine that you are installing or removing, the crane must have an unblocked direct path to where it is going and it must be within four tiles of it."

Which should be more clear.

Regularitee commented 6 years ago

@kevingranade I didn't realize the word "horrible" was an uncivil word. It was my understanding that the word horrible was not particularly uncivil if used to describe something abstract (horrible weather, a horrible part of town, a horrible crash, or in this case, horrible design). Doubly so because my criticism here was constructive, providing my reasoning and recommendations.

Though if even that is too harsh for use, it might be more prudent to setup a word filter to ban the term completely.

mlangsdorf commented 6 years ago

Some cranes parts (forklifts, primarily) aren't cranes until they're installed in the vehicle. The base item is a frame.

The correct place to get information about a vehicle part is in the vehicle interaction menu. If you don't like the description, please suggest improvements but adding more to the base item description is not a good solution.

mrkybe commented 6 years ago

@Regularitee is the intended description clear?

derpkerk commented 6 years ago

Chill out, if you cant be civil, we dont want your bug reports. implying that you are 100% civil all the time

guys if you were in his situation you would react with the same words. It is up to the receiver to take the mood into account when he after a bug encounter that prevents him from playing his weak character can't go on and is frustrated.

you receive frustration here. That is what motivates for a bug report, so that others don't have to have that feeling.

you chose to do this so not even "counter-abuse" is justified. it's just emotions involved for some. ANd you'd do good not to overreact with intimidation

@Regularitee some people don't react when it is their turn to retract something. I say you are owed one apology. Hopefully you'll get it.

Regularitee commented 6 years ago

@mrkybe Yeah. I'd also add a blurb to the item itself (when it's not attached to a vehicle), since people should know restrictions on the item's use before they install it (otherwise, they'll install it in a place where they can't really make use of it)