search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.62k stars 4.17k forks source link

Previous game's NPC followers have "memory" of new player #26126

Open Ceepert opened 6 years ago

Ceepert commented 6 years ago

Describe the bug
When you have a world that you keep once a character dies, npc´s you have met with your old/dead character talk to a new character, that they never met, like it is the old character.

To Reproduce
Steps to reproduce the behavior:

  1. Create World + Character (make world settings to keep world on death + idealy set spawning npc to always)
  2. Get the NPC to follow you, or get a quest.
  3. Die/Make a new character in the same world.
  4. If you got the NPC to follow you he will, at some point, appear next to the new character, still following you, even though the NPC technicaly has no Idea who you are. (He also still has the same active quests and relationship with you)

Expected behavior
The NPC should react like it doesnt know you since it is a new character.

Versions and configuration(please complete the following information):

Additional context
To get to see this easier, choose the Prison Break scenario with spawning npc, so you can find him more easy.

Leland commented 6 years ago

Updated title to make the exact issue a bit more identifiable

mlangsdorf commented 6 years ago

NPCs and monsters pretty much have a boolean "friendly" attitude for all players. It should really be a faction check in both cases, and each player should have their own faction.

Night-Pryanik commented 5 years ago

I think this should be closed after #29182?

kevingranade commented 5 years ago

New player in same world after death of existing player will not suffer this problem, but a concurrent game will.

mlangsdorf commented 5 years ago

We can try making the your_followers a numbered faction, but there were issues with the loading order the last time I tried this.

I-am-Erk commented 4 years ago

Honestly because so many NPC dialogue conditionals are stored globally, this is a problem that persists in a huge number of NPC settings and would be nearly impossible to fix for most of them. I suggest that we just add a warning when you try to make a character in a world that's been played in before, whether the player is dead or not: "Cataclysm: Dark Days Ahead is not really made for multiple runs in a single world. You may experience some bugs if you have already played extensively in this world. Press "esc" to go back and make a new world for your new character, or any key to continue anyway."

We should also make sure that Play Now options try to select "pristine" worlds if there are any available.

ElonSatoshi commented 4 years ago

And also make the default world behavior be to delete, not keep.

If we did something like that, would that be enough to close this issue?? Or at least to move it out of the 0.E milestone?

I-am-Erk commented 4 years ago

I don't mind that solution, actually. Then the warning could go in the options menu.

ghost commented 4 years ago

Do we now consider this "fixed" for the purposes of 0.E ?

I-am-Erk commented 4 years ago

Yeah, don't know why it didn't auto close when the pr merged

kevingranade commented 4 years ago

This issue has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/followers-retained-by-new-character/25024/2

kevingranade commented 4 years ago

This issue has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/two-characters-three-horses-one-crazy-world/25085/2