CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.32k stars 4.14k forks source link

Build warning treated as error on release=1 GCC 8.2.1 #28077

Closed Treah closed 5 years ago

Treah commented 5 years ago

Describe the bug
Build error. `src/sounds.cpp: In function ‘void sfx::do_ambient()’: src/sounds.cpp:610:43: error: this statement may fall through [-Werror=implicit-fallthrough=] play_ambient_variant_sound( "environment", "WEATHER_SNOWSTORM", heard_volume, 20,

                                             1000 );

src/sounds.cpp:612:13: note: here case WEATHER_SNOW: ^~~~ cc1plus: all warnings being treated as errors make: [Makefile:813: obj/tiles/sounds.o] Error 1 make: Waiting for unfinished jobs.... `

To Reproduce
Steps to reproduce the behavior: Pull current build with updated Arch Linux x64

Expected behavior
Clean compile without error.

Versions and configuration(please complete the following information):

ghost commented 5 years ago

from #27870 , Ill fix in a bit.

Brambor commented 5 years ago

It is said that it is fixed (see last reference)