CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.64k stars 4.18k forks source link

Bulletin board after fully upgrading faction camp causes Nothing tile. #28808

Closed Crafty908 closed 5 years ago

Crafty908 commented 5 years ago

Describe the bug
Asking the camp overseer to create a bulletin board after fully upgrading survivor base tile creates a nothing tile, erasing all upgrades such as palisades, tents, and any player constructed furniture.

To Reproduce
Steps to reproduce the behavior:

  1. Fully upgrade a survivor camp tile
  2. Ask the overseer to create a bulletin board and do something more useful
  3. Tile changes to a nothing tile

Expected behavior
The camp overseer creates a bulletin board and the camp retains its upgrade level

Versions and configuration(please complete the following information):

Additional context
@davidpwbrown

ghost commented 5 years ago

currently investigating. Appears there is a crash when creating a new camp aswell. Which was not present before merging - perhaps recent panels PR changed editmap.cpp somehow, cant see how though, but will dig further.

ghost commented 5 years ago

Ok I changed the logic in updating the camp after overseer resigns, should fix it, some weirdness , including a crash was caused by editmap() being affected by the recent panels UI PR changes. So I think that fixes both of these problems.