You pour water (frozen) into the || plastic canteen.

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.

http://cataclysmdda.org

Other

10.68k stars 4.19k forks source link

You pour water (frozen) into the || plastic canteen. #28882

Closed l29ah closed 5 years ago

l29ah commented 5 years ago

To Reproduce
Dunno, after saving and re-loading i get The toilet water is frozen solid!

Versions and configuration(please complete the following information): 0.D-760-g45d0f89a1d-dirty

alanbrady commented 5 years ago

More information is required. A save game or something might be nice too.

l29ah commented 5 years ago

I've just reached a town, found a place to sleep, slept, woke up and went to a toilet. 2019.03.20.zip

alanbrady commented 5 years ago

So I'm guessing the bug being reported here is the fact you were able to reload your canteen with frozen water?

What I'm guessing happened is it started to freeze after you started to reload it which is kind of an ugly corner case that if it were fixed would be more of nuisance to the player if it backed out of the refill if it started to freeze in the middle of it.

Again just guessing since it's not what clear what issue is being reported here given the barest of details. I tried playing with your save game and couldn't reproduce anything peculiar with the canteen or toilet. Not sure where to go from here.

l29ah commented 5 years ago

No, the toilet told me it was frozen when it asked me whether i want to fill/use it.

l29ah commented 5 years ago

And it was this way until i saved the game and reloaded it.

alanbrady commented 5 years ago

What sequence of commands allowed you to fill it whilst frozen, specifically?

l29ah commented 5 years ago

e, direction key.

alanbrady commented 5 years ago

It seems like some detail is still missing because I am unable to reproduce the issue as described.

Using provided save game, spawn a plastic canteen
Press e, up, toward toilet
Nothing happens, as expected

You're using a dirty source tree, have you made some modification to the source? Is the issue reproducible without your modifications?

l29ah commented 5 years ago

As i've said, i cannot reproduce it as well. No modifications that i've done, the source is built with https://github.com/leycec/raiagent/blob/master/games-roguelike/cataclysm-dda/cataclysm-dda-9999-r7.ebuild

Night-Pryanik commented 5 years ago

Closing until confirmed then.

TheMurderUnicorn commented 5 years ago

I don't know how to reopen an issue, but this also happened to me. I was recording at the time, so here's some screen shots. I was loading water from a pump into a gallon jug.

Here's the message displayed:

001

And here's a shot of my inventory a few seconds later:

002

I also just teleported back to the farm and tried again. At first it gave just cold water, but after changing the weather to snow and waiting around until midnight, it began to allow me to 'pour' the frozen water into my gallon jug. So, I can provide a save game illustrating this if you're interested.

TheMurderUnicorn commented 5 years ago

https://drive.google.com/open?id=1jInEXE7ytplHxRtOkAl49OFzPwtl4JDT

That's the save, never pulled a save before, I hope it's right. Should be right next to the pump and 'e'xamining it to put the water in the jug will produce frozen water. Also worth noting that you can 'u'nload the frozen water from the jug, but I imagine that probably holds for most frozen liquids.

Hirmuolio commented 5 years ago

Taking water from a pump/water tile has some odd interaction.

An item (liquid) is created and set to enviroment temperature.
The item (liquid) is placed inside the target container.

If enviroment is below freezing temperature then the result is frozen liquid being placed in a container.

Two possible solutions:

Do not allow taking water if enviroment is below freezing temperature (would be odd since map water can not freeze currently)
have a floor temperature of maybe 4 C so that the result can't be set colder than this.

I don't think the result frozen water from this should behave any different from normal frozen water in containers.

AFAIK water in toilets does not behave like this. This is unique to water pumps and water tiles.

kevingranade commented 5 years ago

It's because theres no water item on the map initially, right?

Hirmuolio commented 5 years ago

Yeah. The items are created on the fly.

l29ah commented 5 years ago

Reproduced it again when i woke up in a mansion and rushed to a toilet for water.