berangus commented 5 years ago

Describe the bug

NPC vendor is offering to pay more to buy certain items than he is charging me to buy them from him. I can repeatedly buy and sell the same items to him and turn a profit doing so. This is with bartering skill 4, and the NPC I tested with is "the intercom" at hub 01. The items I observed this occurring with are "science ID card", "military ID card", "screwdriver set", "Principles of Advanced Programming", and "Advanced Economics". Seems like a lot of items are affected, but not all.

Update after testing: it seems like as I iterated over this process, more and more items began to be favorably tradeable, until eventually I think every single item was tradeable at a profit. I'm not sure what caused this change, but for example note that my compound bow+3 was valued at $825 in my initial screenshot, and $853.50 in my aftermath screenshot. Other items (but not all items) were similarly affected, such as my steel spear which was originally valued at $240 and ended up valued at $256.50. Yet other items, like the EMP grenade and inactive manhack were unchanged. My bartering skill did not improve (in fact it did not gain any skill progression from all these transactions, not sure if it is supposed to or not).

Steps To Reproduce

Steps to reproduce the behavior:

Visit a trading NPC (might require bartering 4+ for this to work)
Trade them at least one of the above listed items while retaining at least one of them in your own inventory
Observe that you can trade the same item for itself and make a profit in the process
If you do this enough you can eventually scam the NPC out of everything they own while giving up nothing in return

Expected behavior

NPC vendors should at best trade items at equal value.. the player should not be able to generate money by repeatedly trading the same items back and forth.

Screenshots

Screenshot of vendor's initial stock, and 4 science ID cards being traded for 4 science ID cards with a $70.00 profit for me: vendor bug

Screenshot of the aftermath, after repeatedly trading items back and forth: vendor bug aftermath

The poor intercom, after starting with thousands of dollars of merchandise, is left with just a single piece of solder, valued at $0.28. I could have gone lower and left him with just an antifungal drug (valued at $0.15) but let's be honest, there's no way those prices make sense.

Versions and configuration

OS: Windows
- OS Version: MINGW/CYGWIN/MSYS2 on Windows 7 Ultimate 64-bit
Game Version: 0.D-5125-ge42e973 [64-bit]
Graphics Version: Tiles
Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Icecoon's Arsenal [ew_pack], Makeshift Items Mod [makeshift], Medieval and Historic Classes and Shields [Medieval_Stuff], More Survival Tools [More_Survival_Tools], Alternative Map Key [alt_map_key], Modular Turrets [modular_turrets], Salvaged Robots [Salvaged_Robots], More Locations [more_locations], Fuji's More Buildings [FujiStruct], Folding Parts pack [deoxymod], Vehicle Additions Pack [blazemod], Tanks and Other Vehicles [Tanks], StatsThroughSkills [StatsThroughSkills], Magiclysm [magiclysm], DeadLeaves' Fictional Guns [FIC_Weapons], Mythological Replicas [nw_pack] ]

Additional context

Don't worry, I already had the Telescopic Eyes CBM, I'm not a filthy cheater

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.