CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.32k stars 4.14k forks source link

Publish CDDA on flathub #33682

Closed rohanlean closed 1 month ago

rohanlean commented 5 years ago

Is your feature request related to a problem? Please describe.

Flathub is a popular repository for flatpaks -- application bundles that are portable across many different linux distributions. It would be convenient for users if CDDA were published there.

Describe the solution you'd like

A maintainer on the release team should make a submission to flathub (https://github.com/flathub/flathub/wiki/App-Submission) and update it whenever a release is made.

Describe alternatives you've considered

A person not as closely affiliated with the project could make the submission. This is a worse solution, because it compromises the (perceived) authenticity of the app, and releases are not guaranteed to propagate in a timely manner. Flathub also prefers for the maintainers to be in charge of submissions.

Additional context

33658 has updated the manifest org.cataclysmdda.CataclysmDDA.json so that it can essentially be submitted on its own and as-is. Flathub guidelines (https://github.com/flathub/flathub/wiki/App-Requirements) suggest not just a tag but also a commit to be specified, but this seems not to be a requirement, and it would be a trivial fix that can be applied on submission.

A more serious obstacle is that the Appstream data data/xdg/cataclysm-dda.appdata.xml are missing:

This needs to be fixed, and the fixed Appstream data referenced by a submission of any release that predates the fix. For example it could be included in the submission, together with a slightly adapted manifest.

I feel that I am not in the best position to select screenshots and a content rating, but I have given the content rating a try:

intense intense intense moderate moderate moderate moderate moderate intense mild

You can generate your own at https://hughsie.github.io/oars/index.html.

The guidelines for screenshots are found in here: https://www.freedesktop.org/software/appstream/docs/sect-Metadata-Application.html. I suggest involving the larger community in selecting screenshots.

rohanlean commented 5 years ago

This ended up sounding less actionable than I had anticipated -- I went through the requirements only as I was writing this issue -- and perhaps that explains the lack of engagement?

I could open another issue for the selection of promotional screenshots and submit a [CR] PR for the content rating. Once those two are taken care of I can give short and explicit instructions on how to perform the submission (and keep it up to date). Would that help?

kevingranade commented 5 years ago

I'm 100% ok to do the actual submission, but setting up the actual metadata and such would be so far down on my list of priorities that you can pretty much count on it never happening if you leave it to me.

stale[bot] commented 5 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not \'bump\' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

stale[bot] commented 4 years ago

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

hexagonrecursion commented 3 years ago

Can this be reopened? I want to work on getting cdda into flathub.

anothersimulacrum commented 3 years ago

@hexagonrecursion Still interested?

skossan commented 2 years ago

I would love to see this on Flathub. Would be awesome if someone would make it happen!

barthalion commented 2 years ago

The manifest itself looks good, but the appdata file is going to need some changes, specifically it misses screenshots. @skossan, why don't you follow the steps described at https://github.com/flathub/flathub/wiki/App-Submission? We will figure out who from Cataclysm team would like write access to the Flathub repo as part of the review.

a-chancey commented 2 years ago

I'm going to look into this a bit, maybe early next week. trying to read up on flatpak, as i just got my steam deck heh

a-chancey commented 1 year ago

Ok, reporting back now that i had a bit of time to mess around with it. I had to update the manifest to match the version of FreeDesktop I have installed, but the build works, installs and launches properly. I'll review the app submission steps for FlatHub and figure out what's missing (other than the aforementioned screenshots), then get things set up for submission. One caveat - FlatHub only allows stable builds, so I don't know if we'll be able to host the flatpak experimental builds here or how we'd handle them.

barthalion commented 1 year ago

My understanding is that nightly builds of CDDA is what many people use. I don't think such submission would be rejected, as long as there's some biweekly or weekly update schedule; it would make sense to me submit it separately so users can install both versions at the same time.

Aman9das commented 1 year ago

One caveat - FlatHub only allows stable builds, so I don't know if we'll be able to host the flatpak experimental builds here or how we'd handle them.

There is the beta branch of flathub too. As described here: https://github.com/flathub/flathub/wiki/App-Maintenance

a-chancey commented 1 year ago

One caveat - FlatHub only allows stable builds, so I don't know if we'll be able to host the flatpak experimental builds here or how we'd handle them.

There is the beta branch of flathub too. As described here: https://github.com/flathub/flathub/wiki/App-Maintenance

Yeah, though over here, they explicitly state that it's for semi-stable beta builds and not nightly, and our experimental branch is/can be more frequent than nightly.

here's a slightly more recent discussion re:nightly/development snapshot builds that largely reflects the same policy.

When I've got a little more time, I may look into updating the build action for flatpak to list the stable, just haven't gotten to it yet

barthalion commented 1 year ago

It's true, but we're flexible when it makes sense. Projects like Citra, Yuzu and Ryujinx are updated almost daily with our blessing.

RustoMCSpit commented 10 months ago

any update?

RustoMCSpit commented 1 month ago

should this be closed now