CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.63k stars 4.17k forks source link

Applying a lighter to an existing fire increases fire size. #3385

Closed kevingranade closed 11 years ago

kevingranade commented 11 years ago

in iuse.cpp, the helper method resolve_firestarter_use() simply does: g->m.add_field(g, point(posx, posy), fd_fire, 1, 100) This has the unintended consequence of instantly upgrading a small fire to a fire, and a fire to a raging fire. I suggest having prep_firestarter_use() return false and print an error message when the player tries to "light" an existing fire. Possibly also have resolve_firestarter_use() refuse to increase the size of an existing fire.

Rivet-the-Zombie commented 11 years ago

Well, it seems to me that lighting additional spots on the fuel object should be able to make the fire bigger within reason - turning a small fire into a fire for example. It's that turning a fire into a huge raging inferno step that seems weird.

i2amroy commented 11 years ago

I'm not so sure about that. In-game a small-fire is your average campfire/fireplace size, a normal "fire" is more like the a small tree burning. Also keep in mind that really the size of the fire here should be limited by the fuel; regardless of how many times I light that book on fire it won't get any larger without more fuel.

kevingranade commented 11 years ago

What we're talking about here is applying a butane lighter to some fuel and getting a small, stable fire. Stretching a bit still, but good enough. Then you hit the fire with another 6 seconds of teensy butane, and you have a crackling campfire roughly two feet in diameter... wat

ianestrachan commented 11 years ago

This is a bug? I honestly thought it was intended behavior by forcing you to triple the amount of fuel you burned through to get a good fire going.

Makes sense, though. I'm going to miss being able to instantly make a house start collapsing with three flicks of the bic.