search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
9.95k stars 4.08k forks source link

Petpacks lets you stack animals #34069

Open EirenexTheDragon opened 4 years ago

EirenexTheDragon commented 4 years ago

Describe the bug

you can pack a small pet in a petpack, make another pet wear it and pack that pet in a petpack, and then you give said petpack to a new pet that you would then pack again and so on. there is also no change of weight when you keep stacking them on or something.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Debug spawn animals, that you then tame afterwards. get a couple petpacks aswell
  2. Pack the first pet and make another pet wear the petpack that contains a pet. pack that pet that carrys the petpack in a petpack aswell and repeat as many times you like
  3. enjoy the Cataclysm way of Babushka Dolls when you unpack them

Expected behavior

I am fine if a pet can carry a petpack, but it shouldnt allow you to pack a animal that carrys a petpack which contains a pet already

Screenshots

For this Screenshot i put a petpack on Multiple puppys and a Normal dog will carry them all. grafik

Versions and configuration

Additional context

Noone

Sirbab commented 7 months ago

There's also some weirdness likely associated with this. If you have two petpacks with different animals, and release one of them, the inventory displays 2 empty petpacks in your inventory. You can resolve this by dropping one of them, and activating the one that has the pet still in it.

RenechCDDA commented 3 months ago

There's two components to this:

1) Animals did not respect carry weight. This was fixed by #65901

2) The bag weight of an animal is not added to a monster. One of these four petpacks' bulldogs is carrying a petpack with a siamese cat inside it, but they're all the same weight. image (Note: I'm not sure the weight SHOULD be added, monster weight is pretty much only used for butchering, I believe)

But this is a really minor issue, as there is a distinct limit to the amount of matryoshka petpack-inside-a-petpack shenanigans you can do.

Based on the fact the main exploit was fixed, I'm not considering this a blocker for 0.H.