CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.68k stars 4.19k forks source link

Trading adds/subtracts from NPC max volume/weight weirdly #34649

Closed molkero closed 5 years ago

molkero commented 5 years ago

Describe the bug

Trading stuff from NPCs affects their max volume/weight in the trade screen, so that they can go negative volume if you take items from them.

Steps To Reproduce

Steps to reproduce the behavior:

  1. Find and trade with an NPC.

Expected behavior

Taking items from NPC would give them more space, giving them items would give them less space.

Screenshots

This NPC has 2,5L of storage and a 2,5L canteen. Taking the canteen makes him go from 0 volume to -2,5L. 20191011145055_1 Giving him stuff also gives him more available volume and weight. 20191011145123_1

Versions and configuration

Additional context

Noticed this because my NPC friend is a bear and can't wear much other than an XL jumpsuit with not much storage.

EDIT: Propably not related, but every time I visit the trade screen, I get a message "NPC drops a ." in the log.

ANickelN commented 5 years ago

Trading is borked right now, this is probably related to the game crash when trading at refugee center.