search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.26k stars 4.12k forks source link

Game warns of zombies being aimed at #36088

Closed glenmack closed 4 years ago

glenmack commented 4 years ago

Expected behavior

Not interrupt aiming at a particular zombie to tell you it is there.

Actual behavior

Only one zombie in sight, already aiming at it, steadying aim is interrupted to tell you X type zombie approaching.

Steps to reproduce the behavior

Aim at approaching zombie with safe mode on.

Ramza13 commented 4 years ago

Pretty sure #35983 will fix this. EDIT: It doesn't as pointed out.

glenmack commented 4 years ago

Pretty sure #35983 will fix this.

From what I've read, no it doesn't. Your fix ignores things based on distance and z-level. Not on whether it is being aimed at or not. I will still want to be informed of other approaching monsters just not the particular one I'm aiming at because I already know it is there.

Ramza13 commented 4 years ago

Pretty sure #35983 will fix this.

From what I've read, no it doesn't. Your fix ignores things based on distance and z-level. Not on whether it is being aimed at or not. I will still want to be informed of other approaching monsters just not the particular one I'm aiming at because I already know it is there.

Good point.

JeanLucVanDamme commented 4 years ago

I will still want to be informed of other approaching monsters just not the particular one I'm aiming at because I already know it is there.

Agreed. This is incredibly irritating when playing as ranged characters. Yes, I know it's been sighted, that's why I'm aiming.

Sometimes it's even the only creature in sight, and you're prompted several times at different distances. Sometimes the creature is super low-powered and poses no threat at any distance.

Ramza13 commented 4 years ago

So I have been looking into fixing this and have some questions.

First while I remember this happening to me I'm having trouble reproducing it for testing, does anyone have steps/settings to force it to occur?

Second I noticed in the code that at present the warning about a monster being dangerously close will not happen while you are aiming regardless of target. It would be quite easy to move this check from where it is to happen anytime you spot a monster.

This isn't quite the ask but would be very easy and is already the behavior of the dangerously close warning which is supposed to be the last line of defense so it would standardize the behavior.

Would this be considered an acceptable fix?

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not \'bump\' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

stale[bot] commented 4 years ago

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it