CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.25k stars 4.11k forks source link

Using wire instead of car springs in small-scale recipes #37211

Closed randomtyper closed 4 years ago

randomtyper commented 4 years ago

Is your feature request related to a problem? Please describe.
There is only one type of springs in game, Specifically - car spring, that is used in many recipes that IRL should use small springs. For example, nail rifle mag, that has volume of 250 ml and weight of 60 g, needs you to file down (without using a file) a 3 kg and 750 ml spring. Sounds absurd and stupid, isn't it?

Describe the solution you'd like
Changing car springs in small-scale recipes to wire (quickest and easiest solution).

Describe alternatives you've considered
Adding in a new item - small spring, that can be crafted using a wire as material and electric drill and rebar as tools (there may be better variants) - would be hard for me. Continue to cram car springs into magazines and weapons.

Additional context
I made this issue to figure out what variant of solving this problem is better and how I can improve the final solution without making a PR with a lot of edits (and redundant work), so feel free to comment. https://www.instructables.com/id/Make-your-own-springs-in-seconds/ - making springs at home from wire using a drill and a steel rod. About wire: how long is one length of it in-game? This may be needed for calculation.

Kilvoctu commented 4 years ago

I think it makes sense and realistic to prepare the small spring component first, than to put wire in one's end product and imagine it's small spring. It could be confusing for some recipes as to why wire is needed. Also small spring could eventually be added as materials gained from disassembly, rather than wire.

Ker-Nes commented 4 years ago

Supporting the addition of a small spring item. While laborious, it shouldn't be hard, just requiring to go through all recipes that currently the car spring item and check if they should use a small spring instead, altering as needed. Maybe we make a collaborative fork to do that if it turns out that there are too many recipes?

Rebar is probably unnecessary though. A small spring probably can be coiled even around the drill itself, depending how small we assume they are, and if we assume they are a bit bigger, a pipe, broom (for the handle) or the similar should be a good enough replacement, as it's not quite that much strength needed to bend the wire into a spring. Maybe copying the chainmail link recipe?

Most annoying part is probably populating the loot lists, and to decide where they should appear, but that's honestly secondary, specially with them easily craftable.

ghost commented 4 years ago

Springs require heat treatment to actually store energy and not deform, even assuming random wire has sufficient carbon content (mild steel doesn't).

TechyBen commented 4 years ago

They'd end up more slinky than spring. But yes, springs from washing machines (medium sized IRL) and VCRs (small sized IRL) are common. Though VCRs are now defunct. The guitars, heaters, etc could have small springs (though are these too wobbly/soft?) when disassembled.

Could add small springs as a possible drop to computers/terminals being dismantled. They are common in sprung doors/panels or CD players. Possibly ovens too, for the sprung door (should be smaller than the washing machine spring).

Currently, the springs from car seats would also be around medium sized (IIRC mattresses in game don't produce springs, but these would also be medium sized I guess). With only car suspension coil springs being the common source for large springs.

ghost commented 4 years ago

Thing about springs is you never get the right size from disassembly. Making your own is the right solution when trying to improve realism in this regard, but thinking that random wire wound on a dowel makes a spring is arguably going in the opposite direction (at lest with car spring you can rationalize it was a close enough and you cut it to size, as long as you're willing to ignore size/weight)

IMO sensible option(s*) would be

AH1684 commented 4 years ago

If you've an appropriate wire material (e.g. piano wire), all you need is the dowel rod (maybe a power input depending on the size, e.g. drill or lathe), pliers, and wire cutters can create small and medium springs. Heat treatment isn't necessary in all cases. High strength wires could be looted from appropriate sources, providing another loot source for springs. Though adding a new material class may not be desirable.

AH1684 commented 4 years ago

Alrighty, now with some free time amidst, I can work on this as a first contribution! One that has also bugged me when playing the game. Current Proposed solution: Creating a small spring would require a cordless drill and a rod to turn the spring wire on at a consistent rate. Small pliers are then used to finish off the spring.

Tools: A tool with drilling 3 - a cordless drill A heavy stick - to turn the spring wire on Pliers - To form the wire.

Materials: 1x Wire

Time: 25 minutes

Output: 10x Small Springs

In addition, current springs will be clarified as "car springs" and the new springs as "small springs". Recipes will use either or based on object size and spring strength.

Possible Alternatives

  1. Introducing the "turning" tool quality. Though this may be out of the scope of this issue, moving forward with lathe-like tools is important for a crafting reform.
  2. Requiring a machinists' handbook - Something I feel unnecessary in the current 0.E version, but also may be considered after crafting reforms.
  3. Requiring wire cutting quality and tool - Small wire cutters to work with smaller projects. I felt requiring metal cutting or bolt cutters was egregious, but not requiring some sort of wire cutting feels off.

Rejected Alternatives

  1. While it is true quality springs are made out of high strength steel alloys, springs have sufficient freedom to be designed around lower quality steels. In the case of the apocalypse, designing a working, though not ideal, spring is fine in the bulk of scenarios. (Mild Steel Springs are going to be a good bit larger for similar max loads at a given stiffness compared to piano wire.) Additionally, the current crafting implementation does not include a robust materials/metallurgical system. I feel small springs are important to implement to without a robust materials crafting in the mean time. In the future, however, a crafting reform may consider "precision springs" which need to be made out of high strength steels. Thus I feel requiring forging/quenching equipment isn't necessary for small springs. A short design case study can be written up to support this point.

LMK whether this works or not as an implementation! Happy to take feedback!

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not \'bump\' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

stale[bot] commented 4 years ago

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it