CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.59k stars 4.17k forks source link

Can fall when climbing down a stepladder #39892

Closed sick-trigger closed 4 years ago

sick-trigger commented 4 years ago

Describe the bug

You can slip and fuck yourself up when climbing down onto a stepladder, despite it saying you should be able to climb back up easily.

Steps To Reproduce

  1. place stepladder next to building
  2. climb up and down it over and over until you fall
  3. break legs, rage quit

Expected behavior

using a stepladder to climb down a roof should be 100% safe. When climbing down from a roof via an unsafe method the game should /very clearly/ indicate you might fall off for massive damage.

Versions and configuration

Additional context

The changes to climbing down added in #39635 were incredibly rude and falling off a roof is infuriating when it happens.

A better solution is to put it back how it was, where you can either safely climb down somewhere or you cannot, without any RNG, and with a clear message indicating that you're about to fall, and then just remove climbing up downspouts altogether, with maybe some exceptions for the parkour trait.

Night-Pryanik commented 4 years ago

You can slip and fuck yourself up when climbing down onto a stepladder, despite it saying you should be able to climb back up easily.

And where's the contradiction? You really can climb back up easily, it doesn't say anything about climbing down easily or safely.

using a stepladder to climb down a roof should be 100% safe.

When you're climbing down from any roof, you're NOT using stepladder, or downspouts, or any other furniture or terrain. It's simply not implemented at the moment. Every time you climb down from a roof, in fact you're climbing down, using only your hands, that's why you can really easily slip down and fall off.

When climbing down from a roof via an unsafe method the game should /very clearly/ indicate you might fall off for massive damage.

Isn't that obvious? Climbing down from a roof is dangerous as hell.

rage quit infuriating

Maybe you should calm down a little? Even if it's a bug and must be fixed, it's not a reason to go into berserk mode.

sick-trigger commented 4 years ago

when you try climbing down somewhere without something below to climb down you get a message warning you that it might hurt, which gives the impression you don't have to worry about damage when the message is only concerned with how difficult it'll be to get back up (which is how it used to behave)

using roofs to escape and abuse monster behaviour does need to be balanced somehow, but a random chance for your character to just be clumsy and receive lots of damage and pain is frustrating for the player. If you can safely climb up somewhere it stands to reason that you should be able to safely climb down the same route, assuming you are in the same state and the zombies haven't smashed your ladder

(and sorry is my word choice was too strong it's no worries :p)

Tamiore commented 4 years ago

It feels like there should be an option for very slow, but safe decent (as long as you are going just a single Z-level down).

By "slow" I mean 30+ seconds. And by "safe" I mean "some pain and falling prone as the worst outcome".

Night-Pryanik commented 4 years ago

but a random chance for your character

The chance is not totally random. It's based on character's dexterity. For a default 8 dexterity character the chance to slip down while climbing is 12.5%. Sure, it could be tweaked to be more/less frequent, but I think removing it altogether is a step back.

If you can safely climb up somewhere it stands to reason that you should be able to safely climb down the same route, assuming you are in the same state and the zombies haven't smashed your ladder

As I said previously, currently you don't climb down the same route as you climbed up. Climbing down doesn't take any furniture/terrain you used for climbing up into account. Essentially you're asking for a serious rework of "climbing down" mechanics.

sick-trigger commented 4 years ago

it must consider furniture on the terrain at some point because you get a different message when examining a tile with a stepladder below, compared to the tile next to it, or the same tile with the stepladder removed. 'Should be able to climb back easily' vs. 'Jumping down might hurt', as well as what seems like an increased (what used to be guaranteed) chance to clamber down without issue

wapcaplet commented 4 years ago

There is a problem with inconsistent messaging here. just as @sick-trigger said. I verified in 6c4120d528, a master branch as of today, but any recent version will probably work.

First, setup: Spawn in an evac shelter, spawn a stepladder, set up the ladder next to the outside wall, and climb onto the roof. All well and good - one assumes a sturdy ladder will allow safe passage up and down. Indeed when you climb up, there is no indication whatsoever that climbing back down afterwards could be problematic. All it asks is which tile you want to step off on:

image

Now that we're on the roof, let's x or mouse-over the tiles next to the ledge. One of them is just open air with no support:

image

Pressing e to examine that tile gives the ledge prompt - and if I say climb down, I get a warning that I can't climb down, only jump!

image

On the other hand, the brown tile with my stepladder does show there is a stepladder on the ground below (though it also says "no support", curiously):

image

Unlike before, using examine on this tile, then selecting climb down, I get a different message than before, saying "You should be able to climb back up easily if you climb down there."

image

It sure sounds safe. Guess I'll go for it. Look, I made it down safely! Must be OK. Six more trips up and down, no problem. Then, suddenly, ow!

image

So I agree with @sick-trigger that the messaging is misleading/inconsistent here. It sure seems to suggest that climbing down onto the ladder is safe, and the high chance of it actually being safe only reinforces that belief.

Now, I also agree that climbing down probably shouldn't always be a guaranteed success, but if that's the case, the message needs to suggest that. Rather than "You should be able to climb back up easily if you climb down there", it should say "You are pretty sure you can climb down safely, but you would feel better if you had a rope" (assuming that would help), or even "It looks a lot harder to climb down than it did to climb up here."

Night-Pryanik commented 4 years ago

It looks a lot harder to climb down than it did to climb up here

You can slip down with the same chances both when climbing up and when climbing down.

wapcaplet commented 4 years ago

It looks a lot harder to climb down than it did to climb up here

You can slip down with the same chances both when climbing up and when climbing down.

The chances of falling seem very different when going up and down - in fact I have never yet fallen when climbing up a stepladder. When I tested just now, I climbed up 30 times with 0 accidents. But coming back down, I fell down 5 times out of 30. It's possible I need to do more trials, but I would rather spend the time writing a test case to understand what the different chances are. I believe there is no chance of injury going up.

But either way, the message when examining the ladder from the rooftop should suggest that there is some risk to climbing down, since it is risky.

Night-Pryanik commented 4 years ago

I need to do more trials, but I would rather spend the time writing a test case to understand what the different chances are.

There's no need for tests. Because you added a check for slipping when climbing up for unstable terrain in #39705, you'll never slip down when climbing up by stepladder, as it doesn't have the UNSTABLE flag. We could add an UNSTABLE flag to the stepladder, so you could slip down when climbing up by the stepladder too.

sick-trigger commented 4 years ago

what is the problem with simply having stepladders be safe to use?

sometimes people do fall of ladders, but for every fall there are literally thousands of times a ladder was used safely. If you try and model this, all you're going to have is an occasional little 'fuck you' to a player.

Night-Pryanik commented 4 years ago

what is the problem with simply having stepladders be safe to use?

Maybe that no one volunteered to rework the climbing down mechanics?

I'm tired of repeating that one don't use any terrain/furniture (stepladders, downspouts etc) when climbing down. In order to make "stepladders be safe to use" we need to completely rework the current climbing down mechanics.

Climbing up is already safe for stepladders.

sick-trigger commented 4 years ago

before #39635 they were safe to use, but climbing down a wall without one carried a risk. What, aside from downspout climbing which I'd be in favour of completely removing, was wrong with that behaviour? And why would returning to it require a rework?

Night-Pryanik commented 4 years ago

I repeat it once again. There is no such thing as climbing down the downspouts or climbing down the stepladders. You simply climb down, using only your bare hands. And 100% safe climbing down in this conditions is unrealistic and unfun.

sick-trigger commented 4 years ago

Before the changes, there was such a thing as climbing down a stepladder or downspout. Examining a tile, with a stepladder deployed on the tile directly below, and choosing to 'c'limb down was 100% safe. Doing the exact same thing with the stepladder removed was not. On the stable build you can go up and down a stepladder over and over and never fall. Remove the stepladder, teleport back up and try the same thing and you fall pretty much every time. What is happening if not climbing down the stepladder? This was both more realistic and less frustrating than a 12.5% chance for an average human to lose their footing and severely injure themselves whenever they use a ladder to climb onto a single storey roof.