CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.53k stars 4.16k forks source link

Rework flashlight and headlamp #41730

Closed Ununsept117 closed 4 years ago

Ununsept117 commented 4 years ago

Is your feature request related to a problem? Please describe.

Describe alternatives you've considered

Leaving it as it is.

Additional context

none

MatiasFito commented 4 years ago

Wow @Ununsept117 amazing investigation, i will take on this change after reading all you've found now i can't leave flashlights as they are :smile: . Once i get the bulk of changes i will get back here and we can min/max the survivor lamp disassembly.

MatiasFito commented 4 years ago

@Ununsept117 hello again my dear friend :wave: , i've tweaked the values and played a little bit, it feels balanced and right, i will share the changes here:

Ununsept117 commented 4 years ago

Hi, good work! Here's my solution for disassembly time: I just added this to data\json\recipes\recipe_deconstruction.json and it worked (and still yields components you used in crafting if they're different than rags): { "result": "wearable_light", "type": "uncraft", "skill_used": "fabrication", "time": "30 s", "qualities": [ { "id": "CUT", "level": 1 } ], "components": [ [ [ "flashlight", 1 ] ], [ [ "rag", 2 ] ] ] }

You should also change the weight and volume of headlamp if you haven't already. As for the survivor headlamp, the time is definitely right, I rather meant weight and volume. With your change the weight is increased by 420g and volume by 0,3L when compared to flashlight. As for the mining helmet I think the crafting time should be the same as headlamp, because it would involve making a headlamp and then strapping it on the helmet. I don't know how else it could be done so if you have other ideas please tell me. Also while we're talking about mining helmet, I noticed it can't be crafted with rags or leather patches, and it doesn't exactly make sense if you can craft headlamp with them, and you can make a mining helmet by strapping headlamp on a hardhat.

MatiasFito commented 4 years ago

Oh great, I'll do those tweakings, test it a bit and create the PR then, thanks again :wave: