CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.63k stars 4.18k forks source link

Glass Shards Take Too Long to Move #41934

Open Ichthysdekilt opened 4 years ago

Ichthysdekilt commented 4 years ago

Describe the bug

While many small items (wood splinters, bones, pebbles, etc) are grouped into single piles and moved as one unit, moving glass shards can take minutes to sometimes hours for large piles to perform.

Steps To Reproduce

  1. Spawn or create a large amount of glass shards (500-1000 is okay, several thousand illustrate the issue better)
  2. Pick them up
  3. Put them down
  4. Move them via AIM

Expected behavior

Glass shards are grouped into a singular item like other small objects.

Screenshots

Versions and configuration

RafeHaab commented 4 years ago

As someone who had to "move" glass shards to the trash can on several occasions, I don't see this as a bug. You'll be surprised how much time it takes to make sure you won't step on one later that night when you go to the kitchen to drink some water.

Ichthysdekilt commented 4 years ago

That would be true if you were talking about tons of tiny shards of glass, but this glass is more big jagged chunks that you can make shivs and caltrops out of, less teensy splinters and glass dust. Maybe there should be more than one category for glass breakdown? I'm sure there must be some use for powdered and/or splintery glass - insulation, maybe?

An alternative might be to make picking them up take the current amount of time but dropping them take little to none, if that's possible. You could load a bag with glass splinters for an hour that will take you 2 seconds to dump out.

Duck13Tales commented 4 years ago

Maybe make it so that they are splattered all around but once you "pick" them, they are grouped in stacks just like other things.

kevingranade commented 4 years ago

My expected results is the opposite of yours. You can't simply reach out and pick up a large pile of gravel with your bare hands as a single unit so that's the bug.

How do you deal with this situation normally? You can use a shovel to pick up larger than handfulls of the material at a time and move it to a large container such as a bucket or a wheelbarrow for transport. That's what we should be doing.

stale[bot] commented 4 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not \'bump\' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

stale[bot] commented 4 years ago

This issue has been automatically closed due to lack of activity. This does not mean that we do not value the issue. Feel free to request that it be re-opened if you are going to actively work on it

pcdms-rygonia commented 2 years ago

hi i would just like to mention that i dont mind in-game time taking some time to pick up these (potentially hazardous) loose items, but just to clarify that in my issue above (https://github.com/CleverRaven/Cataclysm-DDA/issues/55654), it is the real-time (cpu) lag that i have been experiencing, (with some other items too, but only when having several items and containers/pockets)

Brambor commented 3 months ago

Expected behavior

Glass shards are grouped into a singular item like other small objects.

That is not happening. The engine is moving away from charges since there are issues with them.

kevingranade commented 3 months ago

The reason I reopened this is that it needs to be addressed, but with some kind of "bulk item movement" feature instead of trying to use the interface intended for handling individual items to manage dealing with huge numbers of tiny items. Most likely all the "work" being done is the inventory system repeatedly trying to place individual glass shards into your character's inventory, that shouldn't be necessary because what you really want is to shovel (or worst case pick by hand) the shards into a bucket or something, and there'd be no need for trying to scatter all the hundreds to thousands of items across your whole inventory.