CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.

http://cataclysmdda.org

Other

10.53k stars 4.16k forks source link

Survivor headlamp does not work when converted to UPS #42349

Closed ektoplazm closed 4 years ago

ektoplazm commented 4 years ago

Describe the bug

Survivor headlamp does not work when converted to UPS power source, the non-converted option (with a light battery) works fine

Steps To Reproduce

Spawn a survivor headlamp
Convert it to UPS
Activate the headlamp
The headlamp is shown as activated, but there does not actually become a light source

Expected behavior

The headlamp works

Screenshots

Versions and configuration

OS: Windows
- OS Version: 10.0 1909
Game Version: 0.E-4329-ga3e5f32 [64-bit]
Graphics Version: Tiles
Game Language: English [en]
Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], No Rail Stations [No_Rail_Stations], Alternative Map Key [alt_map_key] ]

Additional context

andrei8l commented 4 years ago

Part of the reason is that the UPS mod doesn't add a battery well. I've solved that issue but noticed that player::process_items is actually a mess so I'm trying to simplify that. You can use the commit above in the meantime