CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.67k stars 4.18k forks source link

character preset saving things like hunger, tempature, and pain level. #43141

Open ZaricaDemoni opened 4 years ago

ZaricaDemoni commented 4 years ago

Describe the bug

This may not be a bug and is intended for all i know but its strange to be in distracting levels of pain, chilly, and very hungry from loading a preset. All of this seems to have been saved to the character preset when one was made from an in progress world.

Steps To Reproduce

Create new modded world Use the preset, with the mods it was created with. Get random error (image provided, this error usually freezes the game for a bit if ignored or pressing space which is why i included screenshot) Be in distracting pain, hungry, and chilly (all of this was saved back during the cold on load issue. I saved the preset around this time to try and play the character after it was fixed in a new world)

Expected behavior

Not being in distracting pain, while chilly, and very hungry on using a preset?

Screenshots

image

Versions and configuration

Additional context

If this is an intended function of making character presets from in progress games, some in-game warning of what it saves from character state would be nice.

Including both preset and world with mods to save the step of generating a world. World and Preset.zip

Fris0uman commented 4 years ago

After looking through this it seems that (aside from the error message) the actual bug is that you're not also missing HP. Which is caused by this https://github.com/CleverRaven/Cataclysm-DDA/pull/41623

wapcaplet commented 4 years ago

Confirmed in 0.E-6177-g 9f4a1b841d

The character's current pain, hunger, and comfort levels are saved (and reloaded) in the template.

jbytheway commented 4 years ago

(This comment partly inspired by Discord discussion)

There are two potential uses of character templates: saving a template for a character to use in a new game, and transferring a character from one world to another. Ideally the former shouldn't get these features and the latter should. So I guess we can either compromise one of the use cases or make two versions of template creation and make the player pick which they want.