DanteTorn commented 4 years ago

Describe the bug

The weight or volume changes that mods have on weapons makes modifications act counterintuitively a lot of the time. Eg: Adding a holographic sight nerfs aim speed despite claiming to buff it. Adding a folding stock actually makes wield time better despite claiming it makes it worse because of the volume difference.

Steps To Reproduce

Get a gun and some modifications.
Compare stats of gun before and after applying modifications.
Adding mods often appears to make the gun worse because the weight added by, say, a brass catcher reduces aim speed by 20.

Expected behavior

Some change in handling from weapon weight is expected, but adding just a few mods to a weapon can nerf its aim speed drastically which is an extremely important stat.

Screenshots

Screenshot_135 Screenshot_137

Versions and configuration

OS: Windows 7
- OS Version: MINGW/CYGWIN/MSYS2 on unknown Windows version
Game Version: 0.E-2 [64-bit]
Graphics Version: Tiles
Game Language: System language []
Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Aftershock [aftershock], Garden Pots [growable-pots], MST Extra [MST_Extra], Wild Living [WildLiving], DinoMod [DinoMod], Modular Turrets [modular_turrets], Salvaged Robots [Salvaged_Robots], Hydroponics [hydroponics], My Sweet Cataclysm [my_sweet_cataclysm], Mythical Martial Arts [MMA], Zetsukaze's Hair - 0.E EDIT [zets_hair_extensions_undead], Folding Parts pack [deoxymod], Whaleys Hair Mod (UDP Tweaks) [WHALEYHAIR_UDP], Vehicle Additions Pack [blazemod], Aftershock - UndeadPeople Tileset [AftershockUDP], DinoMod - UndeadPeople Tileset [DinoModUDP], Mythical Martial Arts - UndeadPeople Tileset [MMAUDP], My Sweet Cataclysm - UndeadPeople Tileset [My_Sweet_CataclysmUDP], No Acid Zombies [No_Acid_Zombies], No Gasoline Boomers [No_Gasoline_Boomers-DANTE], No Fungal Monsters [No_Fungi], Classes and Scenarios Mod [more_classes_scenarios], Faster Stamina Regen [stamina_regen_buff], Simplified Nutrition [novitamins], Stats Through Kills [stats_through_kills] ]

Additional context

This has seemingly been a problem for a very long time and I'm not sure why it hasn't been addressed yet. It makes sense that adding weight to a weapon would make it handle worse but a lot of people are saying the just don't bother modifying their guns at all because of these issues. Something needs overhauled here.

DanteTorn commented 4 years ago

For folding stocks in particular, I feel that simply changing the description so that it states it reduces both volume and wield time would be appropriate.

SirPendrak commented 4 years ago

Nah, folding stocks needs complete rework.

Hirmuolio commented 4 years ago

There is also iron sights. They do nothing for any gun since the base aiming stats are same as iron sights. Except if the gun has another mod that blocks sights from working. Then iron sights work even if they shouldn't (only offset iron sights should work with this).

Swootch commented 4 years ago

Damn, I didn't even notice. I always just slapped everything on my gun that wasn't bolted down expecting it to improve performance...

jbytheway commented 4 years ago

This seems like a great space for someone to write some unit tests. Should be relatively straightforward to write tests verifying that mods actually move gun stats in the intended direction.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not \'bump\' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.