CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.65k stars 4.18k forks source link

Minireactor plutonium duplication #44150

Closed Laeras closed 3 years ago

Laeras commented 4 years ago

Describe the bug

Removing a minireactor that has plutonium charges in it from a vehicle, then unloading the reactor causes it to create a number of plutonium fuel cells equal to the charges in the reactor. as each fuel cell item can be used to put 500 charges into the reactor when it is in a vehicle, this can be used to mass-generate fuel cells by removing and replacing the reactor.

This bug was found on version #11000, but I don't see anything in the changelogs that indicate that it would be fixed.

Steps To Reproduce

Install minireactor onto a vehicle fill with plutonium cells remove minireactor from vehicle unload you now have many many fuel cells

Expected behavior

I'd expect it to either give me the charge / 500 rounded down worth of fuel cells, as unloading it while it's in the vehicle does, or to give me nothing. I expect it to do so because with its current behaviour, it can be used to make infinite plutonium cells

Versions and configuration

Melodeiro commented 4 years ago

In older version you was getting the empty reactor after removing from vehicle.

Also if reactor is not empty, you can't install it in a car (says you have no reactor), so another solution is might be just banning user from unloading it, but you need to fix that issue first

nulman commented 4 years ago

just ran into this myself, it is still an issue