CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.29k stars 4.12k forks source link

Bulk moving burning items from a tile with fire crashes #46593

Open Cyprex opened 3 years ago

Cyprex commented 3 years ago

Describe the bug

Picking up a burning item from a tile seems to spawn an error message sometimes. This has been happening 2 out of 2 times with a butchered corpse for me.

Steps To Reproduce

  1. Butcher a zombie with clothing and cut up their clothing
  2. set the tile on fire
  3. Try to pick up the burning items

Expected behavior

Ideally a message that pickup failed due to the item burning up

Versions and configuration

This also happens on 0.E.3,so it's an old bug.

Additional context

debug.log

Cyprex commented 3 years ago

I can provide a savegame if you have trouble reproducing this, I was unable to find a crash.log, despite the game providing the usual error message+blackscreen.

Cyprex commented 3 years ago

Here is another different error message, this time I tried to move 30 out of 35 rags 2 tiles with the advanced inventory panel.

  1. set up a burning tile
  2. set up advanced inventory panel to move items from one tile to another
  3. Move part of a stack at once(default hotkey lowercase m, "Move an amount of Item" in ? menu) DEBUG : Lost target item of ACT_MOVE_ITEMS

    FUNCTION : virtual void move_items_activity_actor::do_turn(player_activity&, Character&) FILE : src/activity_actor.cpp LINE : 931 Screenshot_20210107_042117 debug.log

Qrox commented 3 years ago

That's not a crash message, to be precise. You can continue from the debug message by pressing space or ignore.

NetSysFire commented 2 years ago

52426 looks very similar. It appears the code handling this does not account for items disappearing due to fire or rot, possibly more.