search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.63k stars 4.17k forks source link

Bad bridge generated with two bridges next to each other #46844

Open moxian opened 3 years ago

moxian commented 3 years ago

Describe the bug

Please see pictures, note that it's impossible to "drive" to the lab, also note that bridge supports are there, but no bridge road: cataclysm-tiles-20210118-042854 cataclysm-tiles-20210118-043021

Steps To Reproduce

Savefile: Harrisonville - bridge.zip

Expected behavior

Either no "bridge" on the overmap or a drivable roadway there.

Versions and configuration

moxian commented 3 years ago

Update: I misinterpreted things a bit. The bridge supports DO have a bridge road on top of them, but that piece of road is completely inaccessible: cataclysm-tiles-20210118-043825

PaulBlay commented 3 years ago

I thought those represented bridges that were either half finished or had been destroyed during the apocalypse in some way.

moxian commented 3 years ago

That would make sense, but i don't think this was the intention here. Though, I'd be happy if they get reflavored as "bridge construction" or "bridge remains" or something like that!

int-ua commented 3 years ago

Wasn't it fixed by #42581 ?

PaulBlay commented 3 years ago

Looks different to https://github.com/CleverRaven/Cataclysm-DDA/issues/42523 and I've seen 'broken' bridges more recently than that. They're usually next to farms or other buildings when I've seen them. Actually, I wonder if the parallel bridge isn't a red herring and the problem hasn't actually occurred because it's next to a lab building.

I think the title should be something like "Bad partial bridge generated with building next to river". If you look at it, there should be a road end next to the lab entrance but (because it's next to a river) it was transformed into a 'bridge head'.

int-ua commented 3 years ago

22133 definitely looks related but is it a duplicate?

moxian commented 3 years ago

I would assume it isn't. That issue has bridge ramp properly generated, at least, this one doesn't.

I think the issue here is this is a possible bridge configuration

...|..R     # field - regular road - river
..Г-RRR     # field - road turn - bridge - river
..L>---     # field - road turn - bridge ramp - bridge

where the upper - bridge part tries to semantically be a ┙ turn, but fails.

Though i don't actually know anything about how mapgen works, so might easily be wrong.

PaulBlay commented 3 years ago

@moxian

I would assume it isn't. That issue has bridge ramp properly generated, at least, this one doesn't.

That issue was before bridge ramps existed, so I think it is the same problem. Although I would hesitate to call it a duplicate because the way it is expressed changed after bridge ramps came to exist.

l29ah commented 3 years ago

Got this "bridge" today, might be related: screenshot-bridge

l29ah commented 2 years ago

screenshot-bridge

l29ah commented 2 years ago

Another one; seems like it always has to do with a map feature nearby. screenshot-bridge

int-ua commented 2 years ago

Can confirm that boat rental can generate with incorrect bridge on experimental version from last week. But is the latest screenshot right? I don't see a misplaced bridge there.

l29ah commented 2 years ago

On the last screenshot there's a middle section of a bridge at the cursor next to apple orchard.

alef commented 1 year ago

Another one

image

image