Open NyarlathotepZERO opened 3 years ago
Tested on 0.E-9737-g511ddcb with core content pack dda only. The butchering options are missing when mass butchering every animal tested not just fish. The options are there when butchering one at a time.
The culprit is in this code snippet:
https://github.com/CleverRaven/Cataclysm-DDA/blob/fbd5ba72a3ee39f7f7387f89d2b4140c85d26fc7/src/game.cpp#L8415-L8434
In particular, in the check for index != -1
on line 8415. index
of -1
is reserved for multibutchering, but for some reason skinning, field dressing, and bleeding are forbidden for multibutchering. I could remove check for index != -1
by myself, but I want to be sure that this check here is a mistake or oversight, and not an intended thing.
Describe the bug
I had 5 salmon and was not able to get an option to do a bulk field dress/bleed of the corpses. I was able to to it for each corpse separately though. The Butcher all screen returns a 'has no organs' 'has no blood' but when butchering separately this is not the case as a liver was returned, and there was plenty of blood.
Steps To Reproduce
Expected behavior
Seeing as each of the Salmon were able to be field dressed/bled seperately, I would expect these options to be available as a 'butcher all' option.
Screenshots
The fish to butcher.
The 'butcher everything' screen [note:'has no organs' and 'has no blood']
showing the 5 fish available for butchering
showing the screen that is given when butchering a single fish [note all options available, aside from skin]
note the return products after field dressing the singular salmon
Versions and configuration
Platform : Windows_x64 Graphics : Tiles Build number : #11440 Build version: 0.E-9439-g1e8a075 Major version: 0.E
Additional context
none