search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.59k stars 4.17k forks source link

Metallic sounds when moving with Windows sound set to 5.1. #48192

Open Varenik1226 opened 3 years ago

Varenik1226 commented 3 years ago

Describe the bug

Not played since Version 0.E-7938-g8736e6b (tiles) - Build 11203 (Win x64). I have installed latest experimental version (0.E-10149-g894002b (tiles) - build 11539 (Win x64)) in new folder with latest Otopack soundpack. And when I started a new game, after a step in any direction, the game crashes. Same issue with @'s Soundpack. After that, I tried to delete pieces of code in the soundpack file "player.json" with id "plmove". And the game stopped crashing. I still have a folder with build 11203. On that version everything works fine. Sorry for my English =) That's google translate.

Steps To Reproduce

  1. Install CDDA
  2. Install soundpack with movement sounds and choose it in options.
  3. Start new game
  4. Make a step in any direction.
  5. After the crash, enjoy your desktop wallpaper.

Expected behavior

Take more than one step in the game with walking sounds

Screenshots

Versions and configuration

Additional context

There is no crash.log file debug.zip It happens with all new worlds and characters, but maybe you need it. Save.zip

StefanMiletic994 commented 3 years ago

I've got this problem too I use RFF sounds, tried creating new character and still crashes after I updated a few moments ago.

actual-nh commented 3 years ago

Does it crash if you remove the soundpack from your configuration?

chrispikula commented 3 years ago

So I've got a repeatable instance of this, whenever I go up the stairs out of the basement, instant crash.

Would it have anything to do with getting rid of opengles2 in the option file? I use @'s soundpack, if that helps as well.

Grantsboro.zip

options.zip

Game version: 0.E-10149-g894002b [64-bit], Tiles, Build 11539

coyo7e commented 3 years ago

this hit me too with RRFSounds pack as son as I updated, with a loaded and a new character I made as a test. reverting to previous version seems to have addressed it for the time being.

actual-nh commented 3 years ago

What was the most recent version not giving a crash (ideally, with build number)?

Zireael07 commented 3 years ago

@coyo7e: What is 'previous version' for you?

chrispikula commented 3 years ago

Reverting to 0.E-10134-g9b256f6 (tiles) build 11537 fixed the issue for me as well.

I only reverted options.json, VERSION.txt, cataclysm-tiles.exe, and json_formatter.exe. Everything else was left the same. This was done via WinMerge, a file/line-by-line diff utility. Edit: Also, did the extra option in options.json build 11539 vs 11537 bypass string freeze?

coyo7e commented 3 years ago

@coyo7e: What is 'previous version' for you?

https://github.com/CleverRaven/Cataclysm-DDA/issues/48195

actual-nh commented 3 years ago

Is a 11538 build for Windows x64 available?

chrispikula commented 3 years ago

It had a name that the launcher didn't like, let me check via direct download. I can't get my world to load with x86, I get a ERROR : src/main_menu.cpp:1150 [bool main_menu::load_character_tab(bool)] Error: std::bad_alloc on load. So, yeah.

actual-nh commented 3 years ago

Edit: Also, did the extra option in options.json build 11539 vs 11537 bypass string freeze?

It was changing a default, not putting in an extra option (or at least should not have been).

BrettDong commented 3 years ago

Is a 11538 build for Windows x64 available?

Nope, 11538 Windows x64 build timed out, but Windows x86 is available.

actual-nh commented 3 years ago

Is a 11538 build for Windows x64 available?

Nope, 11538 Windows x64 build timed out, but Windows x86 is available.

The question then is whether 11539 errors on a Windows x86 build.

chrispikula commented 3 years ago

Edit: Also, did the extra option in options.json build 11539 vs 11537 bypass string freeze?

It was changing a default, not putting in an extra option (or at least should not have been).

Ah, my bad. Turns out it was the removal of an option that I got mixed up with, with all the versioning back and forth. Turns out options.json removed the following between 11537 and 11539: "Cuteclysm(Alpha), " line 106 "opengles2, " line 125 "{ "info": "Use render batching for 2D render API to make it more efficient. Requires restart.", "default": "Default: True", "name": "RENDER_BATCHING", "value": "true" }, " line 126

actual-nh commented 3 years ago

Edit: Also, did the extra option in options.json build 11539 vs 11537 bypass string freeze?

It was changing a default, not putting in an extra option (or at least should not have been).

Ah, my bad. Turns out it was the removal of an option that I got mixed up with, with all the versioning back and forth. Turns out options.json removed the following between 11537 and 11539: "Cuteclysm(Alpha), " line 106 "opengles2, " line 125 "{ "info": "Use render batching for 2D render API to make it more efficient. Requires restart.", "default": "Default: True", "name": "RENDER_BATCHING", "value": "true" }, " line 126

Blink. Options.json - how did the version change alter a JSON file that's user-generated? (Admittedly, I'm on a mac and using the USE_HOME_DIR compilation option, so it may be different for me. I'm also using curses, so none of the above 3 things really exist for me anyway...)

EDIT: Does it still crash on 11539 if you put back in the opengles2? (And possibly Cuteclysm, if that's the tileset you're using.)

Varenik1226 commented 3 years ago

Does it crash if you remove the soundpack from your configuration?

After removing soundpack, game works fine.

Varenik1226 commented 3 years ago

If necessary, I can provide remote access to my pc for tests.

actual-nh commented 3 years ago

If necessary, I can provide remote access to my pc for tests.

Enough developers use windows x64 that that should not be needed, I think (and would be better discussed someplace where private messaging is possible!); thank you, though!

ZhilkinSerg commented 3 years ago

mxe (and linked libs, like various SDL2 libs) version was bumped on Jenkins before build #11539 was triggered.

ZhilkinSerg commented 3 years ago

Edit: Also, did the extra option in options.json build 11539 vs 11537 bypass string freeze?

No, string was there for a long time - option was just hidden in old SDL2 version we were using.

Varenik1226 commented 3 years ago

Enough developers use windows x64 that that should not be needed, I think (and would be better discussed someplace where private messaging is possible!); thank you, though!

of course I will not provide my data here =)

Varenik1226 commented 3 years ago

For me, the game crashes with any default tilesets. 0.E-10149-g894002b (tiles) - build 11539 (Win x64)

actual-nh commented 3 years ago

of course I will not provide my data here =)

I didn't think so, but habit from being a security admin a while back...

For me, the game crashes with any default tilesets. 0.E-10149-g894002b (tiles) - build 11539 (Win x64)

OK. So looks like the "Cuteclysm" change that @chrispikula noted is not responsible; not surprised, but something to check.

anothersimulacrum commented 3 years ago

Someone should test porting https://github.com/cataclysmbnteam/Cataclysm-BN/pull/355

ProvoGo commented 3 years ago

having the same problem using @'s soundpack build 11359 (win x64)

RoyBerube commented 3 years ago

On Windows 10 and using otopack for sound.

actual-nh commented 3 years ago

Ping: @narc0tiq?

BrettDong commented 3 years ago

Reproducible using Windows x64 build 11539 with Otopack soundpack, instant crash after moving two maptiles: image

BrettDong commented 3 years ago

Stack trace also fails on build 11539 (Windows x64). I intentionally crashed the program via debug menu on both build 11539 (left) and build 11535 (right). The stack trace given in build 11539 is apparently nonsense: image

Varenik1226 commented 3 years ago

Found strange thing. Installed 11537 x64 build, everything works fine with sounpack. Then 11539 x64 build. Even with basic soundpack game feel very laggy in comparsion with 11537....very, veryyy laggy (default render Direct3D). If i change render on any other, lags disappear, but soundpack problems still here =(.

AMurkin commented 3 years ago

That's #48179, probably. Fixed since build 11540.

Theawesomeboophis commented 3 years ago

Problem fixed for me on current version with Otopack. Can you test to see if the problems are still occurring for you on current version?

RoyBerube commented 3 years ago

Started working for me with version 11543 yesterday. I'm curious what fixed it.

Theawesomeboophis commented 3 years ago

Started working for me with version 11543 yesterday. I'm curious what fixed it.

I think it may have something to do with the demangling PR, as the update that contained that is when it started working for me.

actual-nh commented 3 years ago

Started working for me with version 11543 yesterday. I'm curious what fixed it.

I think it may have something to do with the demangling PR, as the update that contained that is when it started working for me.

That was in with 11544, as far as I can tell.

Varenik1226 commented 3 years ago

For 11548 build (x64) on Direct3D render, the game still veeery laggy, checked in options. Game didn't crash on walking, but a strange metallic sound is added to the sounds of walking, as if something metallic hit on a mesh metal fence. (sry for google translate, I hope you understand what this is about).

anothersimulacrum commented 3 years ago

@ZhilkinSerg I think it may be worth leaving the sdl upgrade to after the release, where we have time to deal with these issues.

ZhilkinSerg commented 3 years ago

Please test performance in build 11550.

Varenik1226 commented 3 years ago

11550 Win x64 Lags are still there =( Strange metallic sounds when walking still there too.

ZhilkinSerg commented 3 years ago

Please try 11551 when it is out.

Varenik1226 commented 3 years ago

Please try 11551 when it is out.

How long will it take to compile approximately? For me it's 3:30 am already. If more than a half hour, then only tomorrow.

ZhilkinSerg commented 3 years ago

32 bit is out already, but there is no rush to test today.

Varenik1226 commented 3 years ago

I have not played on x86 before, so I checked the 11550 build for comparison too.

x86 11550 build same as x64: Lags here, metallic walking sound here.

x86 11551 build: No lags =) But metalic sounds still there =(

Varenik1226 commented 3 years ago

Here this sounds, build 11551 x86 with Otopack soundpack. https://user-images.githubusercontent.com/74045419/112876475-48654500-9111-11eb-8fd4-b57b76d8c415.mp4

ZhilkinSerg commented 3 years ago

@ZhilkinSerg I think it may be worth leaving the sdl upgrade to after the release, where we have time to deal with these issues.

Yeah, I agree - we need to test new versions more during next experimental cycle.

Varenik1226 commented 3 years ago

Win x64 build - 11566 Weird sound still there =( Playing on 11537 =(

actual-nh commented 3 years ago

Is the sound problem still there, @Varenik1226? Assuming that it is:

Theawesomeboophis commented 3 years ago

I'm not getting it, can you (the creator of the issue) reinstall the soundpack and see if the problem persists?

On Mon, Apr 12, 2021, 9:50 AM actual-nh @.***> wrote:

Is the sound problem still there, and is anyone else getting it?

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CleverRaven/Cataclysm-DDA/issues/48192#issuecomment-817828751, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARDXS56M6EQTLZUYJY5G4I3TIL3CZANCNFSM4ZVBUYQA .

Varenik1226 commented 3 years ago

Is the sound problem still there, @Varenik1226? Assuming that it is:

* Is it present with other soundpacks?

* Could you change the title of the issue to reference metallic sounds when moving, to help check if anyone else is hearing it?

Yes, with every soundpack.

Found what was the problem, I have a "Creative SB AUDIGY RX 7.1" sound card installed. In the Windows sound settings, I have 5.1 sound. Metal sounds disappear when I set it to 2/2.1 sound. With 11537 build everything was fine with 5.1.

Just checked it with build11576: 5.1 sound - metal still here 2/2.1 sound - normal sounds.

I reinstalled the driver, tried 2 different versions, the result did not change.

Theawesomeboophis commented 3 years ago

Are there any updates available for your sound driver, if so, can you update and retest?

On Mon, Apr 12, 2021, 11:27 AM Varenik1226 @.***> wrote:

Is the sound problem still there, @Varenik1226 https://github.com/Varenik1226? Assuming that it is:

  • Is it present with other soundpacks?

  • Could you change the title of the issue to reference metallic sounds when moving, to help check if anyone else is hearing it?

Found what was the problem, I have a "Creative SB AUDIGY RX 7.1" sound card installed. In the Windows sound settings, I have 5.1 sound. Metal sounds disappear when I set it to 2/2.1 sound. With 11537 build everything was fine with 5.1.

Just checked it with build11576: 5.1 sound - metal still here 2/2.1 sound - normal sounds.

I reinstalled the driver, tried 2 different versions, the result did not change.

— You are receiving this because you commented. Reply to this email directly, view it on GitHub https://github.com/CleverRaven/Cataclysm-DDA/issues/48192#issuecomment-817905961, or unsubscribe https://github.com/notifications/unsubscribe-auth/ARDXS57ILLYEDD4BMGSRE2LTIMGPXANCNFSM4ZVBUYQA .