CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.61k stars 4.17k forks source link

JSONize + rework (mod-used) shock absorber CBM #48199

Closed actual-nh closed 1 year ago

actual-nh commented 3 years ago

Is your feature request related to a problem? Please describe.

This is in response to @Fris0uman's request in #48186.

The shock absorber CBM needs JSONizing if it is to continue being used in mods... and also reworking heavily to be more realistic than the current description. (For instance, no decrease in stored calories, if fat was replaced, or strength/dexterity if muscle, etc was?)

Describe the solution you'd like

I can see a few possibilities:

Describe alternatives you've considered

It getting removed entirely?

If mod maintainers really like how it's currently described, the rework could be limited to JSONizing it.

Mom-Bun commented 3 years ago

Pretty sure the fact that both aftershock and Dark Skies Above use it is due to just well, legacy code and it being CBMs

I'll defer to Candlebury and Maleclypse if we should keep the shock absorber CBM in aftershock however.

actual-nh commented 3 years ago

Pretty sure the fact that both aftershock and Dark Skies Above use it is due to just well, legacy code and it being CBMs

I'll defer to Candlebury and Maleclypse if we should keep the shock absorber CBM in aftershock however.

Understand. Oh - Ping: @Night-Pryanik - you had objected to removing it from vanilla. I'd like to hear from you on this. (It is an interesting and creative CBM - rather steampunk/clockpunk, actually.)

kevingranade commented 3 years ago

It seems likely that even if Aftershock or DSA wants something like this, it's not going to actually be shock absorbers or padding popping out of the user's body, which is neat as that might sound is incredibly far out on the "can't possibly work" scale of things.

Mom-Bun commented 3 years ago

It seems likely that even if Aftershock or DSA wants something like this, it's not going to actually be shock absorbers or padding popping out of the user's body, which is neat as that might sound is incredibly far out on the "can't possibly work" scale of things.

Replacing your legging with springs and pillows sounds incredibly silly, I talked with maleclypse and we figured we'd use feather fall spell for it, and flavor it as a gravity chute, so yeah you are right.

actual-nh commented 3 years ago

It seems likely that even if Aftershock or DSA wants something like this, it's not going to actually be shock absorbers or padding popping out of the user's body, which is neat as that might sound is incredibly far out on the "can't possibly work" scale of things.

Anyone know an open-source clockpunk/steampunk game where this could fit as-is, BTW? @s7eamy?

Night-Pryanik commented 3 years ago

I objected because I don't like content being removed rather than reworked, especially if this content doesn't interfere with something or interrupt something or get in the way for anyone for so long, especially if this content was merged by project leader himself.

EvgenijM86 commented 3 years ago

Shock Absorber CBM can be a combination of 2 things: brain implant that will automatically control your muscles to rotate your body in mid air to land on your legs, and modified legs that are more suited for jumping and landing.

Removing end game content is not a good development direction, because cdda already lacks in end game content.

actual-nh commented 3 years ago

Shock Absorber CBM can be a combination of 2 things: brain implant that will automatically control your muscles to rotate your body in mid air to land on your legs, and modified legs that are more suited for jumping and landing.

Another reasonable alternative.

Removing end game content is not a good development direction, because cdda already lacks in end game content.

Point.

Mom-Bun commented 3 years ago

Shock Absorber CBM can be a combination of 2 things: brain implant that will automatically control your muscles to rotate your body in mid air to land on your legs, and modified legs that are more suited for jumping and landing.

Removing end game content is not a good development direction, because cdda already lacks in end game content.

The project is open source; if you feel that the game is lacking end game content, there is nothing stopping you from forking and setting up your workflow and contributing some except yourself, patience, and the ability to work in a team.

EvgenijM86 commented 3 years ago

Shock Absorber CBM can be a combination of 2 things: brain implant that will automatically control your muscles to rotate your body in mid air to land on your legs, and modified legs that are more suited for jumping and landing. Removing end game content is not a good development direction, because cdda already lacks in end game content.

The project is open source; if you feel that the game is lacking end game content, there is nothing stopping you from forking and setting up your workflow and contributing some except yourself, patience, and the ability to work in a team.

I did exactly that - my local copy of CDDA has this and some other stuff reverted.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not \'bump\' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

Night-Pryanik commented 1 year ago

Closing as stale, since stalebot can't do this by itself.