CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.65k stars 4.18k forks source link

Minor problem with the negative trait 'hates vegetables' (and maybe the other 'hate' ones too) #48312

Open morthein opened 3 years ago

morthein commented 3 years ago

Describe the bug

Choosing the 'hates vegetables' as a negative trait during character creation changes the in-game warnings for vegetables to show a warning about eating them. While this is fine, that warning shows the reason you get a negative is because of an allergy. This is misleading.

Steps To Reproduce

  1. make a character that 'hates vegetables'
  2. start the game and find something with vegetables in them
  3. Notice it's in red and has an eating penalty (good so far..)
  4. eat the item and read the incorrect warning (pictured below)

Expected behavior

I should get eating penalties, of course, but the (allergy) addition of the warning message is very misleading.

Screenshots

Untitled

Versions and configuration

actual-nh commented 3 years ago

Fixing this (if one assumes the hating isn't due to an allergy!) in master could unfortunately cause problems regarding translations - fixing it in the 0.F-dev branch should be another matter entirely.

OliveChukar commented 3 years ago

There are some traits that are hates (food) and others that are (food) intolerance. All of these traits give the same message when you eat the food. They all seem to just cause negative morale implying that they do not represent a medical issue like allergies.

It could probably be changed so all of the traits are hates (food) and the in game message is something like "you hate this food. Eat it anyway?" or the intolerance traits could be kept and harm beyond just negative morale could be added.

actual-nh commented 3 years ago

There are some traits that are hates (food) and others that are (food) intolerance. All of these traits give the same message when you eat the food. They all seem to just cause negative morale implying that they do not represent a medical issue like allergies.

It could probably be changed so all of the traits are hates (food) and the in game message is something like "you hate this food. Eat it anyway?" or the intolerance traits could be kept and harm beyond just negative morale could be added.

The intolerance ones actually might or might not be allergies - although lactose intolerance (inability to digest lactose, a major sugar in milk) frequently leads to milk allergies. Triggering asthma would be one potential consequence of the actual allergy ones.

Night-Pryanik commented 14 hours ago

I see several solutions here:

  1. Rename Hates Vegetables trait to something like Vegetables Intolerance. "Intolerance" ingame is a rather broad term which includes both real allergies like grain or milk as well as ones that are just personal preferences, like junkfood intolerance or vegetarian. New name will be consistent with names of other "intolerance"-type traits.
  2. Change/adjust message to something like "Your stomach won't be happy (allergy or individual intolerance/rejection)."
  3. Combine both of the above.
Zireael07 commented 13 hours ago

1 is a bad idea imo. Intolerances are pretty much real life intolerances (yes you can be intolerant to junkfood, or rather some of the additives in it)

Night-Pryanik commented 13 hours ago

We have also "Meat Intolerance" trait, which isn't an allergy AFAIK, but rather vegetarianism by choice.