CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.61k stars 4.17k forks source link

reconstituted milk makes less than you started with #48468

Closed Comrade-Soupbeans closed 1 year ago

Comrade-Soupbeans commented 3 years ago

Describe the bug

crafting reconstituted milk from condensed milk results in fewer portions than is required to craft it

Steps To Reproduce

look at the recipe

Expected behavior

that adding water to condensed milk would make more portions

Screenshots

image image

Versions and configuration

Additional context

Some recipes also use condensed milk and reconstituted milk as if they were the same (using the same number of portions)

GGgatherer commented 3 years ago

I can't quite see what is wrong here. It all depends on portion sizes for rec.milk and cond.milk. Portions for different items can be of different sizes. Are they for those two? If the end result had different mass or caloric value than the sum of its parts, that would be an obvious bug.

Comrade-Soupbeans commented 3 years ago

the main issue being that i can craft less with the something i've added material to and that you should logically get more servings (but less calories per serving) by diluting it with water

you also lose 3 calories in total (515 kcal to 512 kcal) which doesn't matter much but does make me think that this recipe just hasn't had an audit in a while

Comrade-Soupbeans commented 3 years ago

the actual issue is that i can make more of a given recipe (the requires some form of milk) if i don't add water, which makes no sense

PatrikLundell commented 3 years ago

I agree that logically each condensed milk portion ought to result in a reconstituted milk portion, possibly with some calorie loss (although that ought to happen in the condensing step only). I can see a potential portion loss in the step where the water is removed from the milk to produce condensed milk, but not in the reverse step. It doesn't make sense if the portions of the different stages would be of different "sizes" (obviously the condensed stage would be physically smaller, given that the water has been removed, but it ought to be the rough equivalent of the "size" of the other stages in terms of nutrients.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not \'bump\' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

Night-Pryanik commented 1 year ago

Closing as stale, since stalebot can't do this by itself.