CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.71k stars 4.2k forks source link

Fish trap doesn't work well outside of reality bubble #48485

Open Antrocon opened 3 years ago

Antrocon commented 3 years ago

Fish trap doesn't work well outside of reality bubble.

Steps To Reproduce

  1. Make a player with survival 6, select 'river' start or find river.
  2. Spawn fish trap & bait, wristwatch, find riverbank with fish visible.
  3. Place loaded fish trap, set alarm for 3h
  4. Move away from trap 60+ tiles to leave it outside of RB
  5. Wait for 3h
  6. Return, check result: no fish caught
  7. Repeat test 5-10 times: almost no fish caught at all (1-2 on 10 attempts).
  8. Repeat the test, but stay near fish trap: at least 1 fish is caught on most attempts.

Expected behaviour

Expected not to babysit fish trap, should produce same results (i.e. high chance to catch a fish with survival 6) regardless whether it's in or out of reality bubble

Versions and configuration

Saicchi commented 3 years ago

Mixed results when reproducing with 0.E-10379-g0f86226edf [64-bit]

  1. Created a character with 6 survival, gave myself a wrist watch, fish trap and 5 bait to fill the trap.
  2. Set the trap on a river, set wrist watch alarm to 3 hours and moved 10 map tiles away.
  3. waited 3 hours for the alarm, went back to the river. Repeated this test 5, two of those I got fish and the other three I did not, with 2/3 consuming all bait instead of just one. Repeating this test 3 times again, now waiting for 5 hours instead of 3, I got fish 2/3 times.
actual-nh commented 3 years ago
  1. Set the trap on a river, set wrist watch alarm to 3 hours and moved 10 map tiles away.

I can never remember how large the reality bubble is; would that put the trap outside of it? (The OP said 60+.) EDIT: @Saicchi: You do mean "overmap tiles" by "map tiles"?

PatrikLundell commented 3 years ago

The reality bubble is a 60 tile radius, equal to 2½ overmap tiles, so the distance should be at least 61 tiles (i.e. the '+' isn't inclusive). 10 overmap tiles away is thus well outside of the reality bubble.

OliveChukar commented 3 years ago

I tried this on 0.E-10383-gad91f6a [64-bit] with Dark Days Ahead [dda] only no mods. With survival 3 set 10 fish traps then debug teleported to a place 28 overmap tiles away set 10 fish traps there and waited 3 hours. The traps that were in the reality bubble caught 8 fish the ones not in reality caught 2.
Repeated the test with survival 8 and got 17 fish in the reality bubble and 1 in the place 28 overmap tiles away. I used teleport for these tests so that movement time would not affect the outcome.

actual-nh commented 3 years ago

So it appears that "doesn't work" should be "doesn't work very well" or similar?

morthein commented 3 years ago

Question:

Does the fish traps work with a random chance of fish spawning in the trap or do actual moving fish have to randomly move onto the square the trap is in for it to be trapped?