search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.63k stars 4.17k forks source link

Selecting Large Building/Mall (Food Court) location results in crash #49308

Closed EchoingZen closed 1 year ago

EchoingZen commented 3 years ago

Describe the bug

Selecting Large Building/Mall (Food Court) location during character creation results in the following crash:

DEBUG    : Bad add_spawn(mon_zombie_fat, 1, -16, 8)

FUNCTION : void map::add_spawn(const mtype_id&, int, const tripoint&, bool, int, int, const string&, const spawn_data&) const
FILE     : src/mapgen.cpp
LINE     : 5353

Steps To Reproduce

  1. Create a Custom Character
  2. Select Large Building for the scenario
  3. On the character preview screen where you name the character, hit "/" to select the "Mall (Food Court)" location
  4. The program should give the crash

    You should start in the Mall (Food Court) location without it crashing

    Screenshots

    Versions and configuration

    • OS: [e.g. iOS 8 or Windows 10 or Ubuntu 18.04]
    • Game Version: 9a81a10
    • Graphics version: Tiles
    • Ingame language: System Setting (English)
    • Mods loaded: 'dda', 'no_npc_food', 'package_bionic_professions'

    Additional context

venum4k commented 3 years ago

Just tested it myself, same error happened 7 times with different coordinates, continuing past the errors didn't result in a crash though. 


 DEBUG    : Bad add_spawn(mon_zombie, 1, -7, 22)

 FUNCTION : void map::add_spawn(const mtype_id&, int, const tripoint&, bool, int, int, const string&, const spawn_data&) const
 FILE     : src/mapgen.cpp
 LINE     : 5353

This was on 817307e

I tried once more on 9a81a10 and encountered the same error again, 4 times with no crash. The game seems to work fine after the messages.

EchoingZen commented 3 years ago

Ah, I've always called those crashes. My bad. :) Still think its worth reporting.

EchoingZen commented 3 years ago

Question in the meantime, is there any adverse side effects from starting with Mall (Food Court)? Are these error putting mobs in invalid spots? Just not generating them? I'm one of those folks who wants to play the game "as intended".

NetSysFire commented 2 years ago

Can not reproduce this anymore, I did get some errors which appear related to #53830 though. No crash.

 DEBUG    : loading non-main map at (-140,654,0) which overlaps with main map (abs_sub = (-143,651,0)) is not supported

 FUNCTION : void map::load(const tripoint_abs_sm&, bool, bool)
 FILE     : src/map.cpp
 LINE     : 6699
 VERSION  : 0.F
Night-Pryanik commented 2 years ago

Can't confirm crash either, though I do have errors like @NetSysFire described.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not \'bump\' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.