search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.61k stars 4.17k forks source link

reveal_lab_train_depot doesn't check lab is connected #49462

Closed archigo closed 1 year ago

archigo commented 3 years ago

Describe the bug

The mission MISSION_SCIENCE_REP_5 can end up targeting a lab like the office tower lab which is not connected to the train labs.

This seems to be because target_closest_lab_entrance does not take into account that many train labs do not have their own lab stairs entrance, and this risk finding the entrance to an unrelated lab first.

underground map

above ground map

I think the solution to this is more complex than guarding target_closest_lab_entrance against finding an unrelated lab. The player would most likely assume the quest is bugged if the lab at the entrance they go into does not have the mission target, even if that lab is connected by subway to the correct lab (it's a lot to explore the whole subway network if it's also connected to the city network).

If the quest description mentions that you might have to check the subway connected labs, then at least the player has a clue that they might have to explore.

stale[bot] commented 3 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not \'bump\' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

MNG-cataclysm commented 2 years ago

PR #61000 overhauled the mission and resolved this error. @kevingranade I recommend closing this.

github-actions[bot] commented 1 year ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

archigo commented 1 year ago

PR #61000 overhauled the mission and resolved this error. @kevingranade I recommend closing this.