CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.

http://cataclysmdda.org

Other

10.59k stars 4.17k forks source link

Oxygen tanks in fixed spawn are empty #49574

Open Comrade-Soupbeans opened 3 years ago

Comrade-Soupbeans commented 3 years ago

Describe the bug

Oxygen tanks spawning in Military Base medical closet spawn without any charges every time

Steps To Reproduce

Find a fixed spawn of oxygen tanks such as a military base

Expected behavior

that they be full, at least in this particular case

Screenshots

Versions and configuration

OS: Windows
- OS Version: 10.0 1909
Game Version: 0.E-10395-g4525b4f [64-bit]
Graphics Version: Tiles
Game Language: System language []
Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Bionic Professions [package_bionic_professions], Blaze Industries [blazeindustries], Gun Cotton [guncotton], Graphical Overmap [Graphical_Overmap], Stats Through Skills [StatsThroughSkills], Useful Helicopters [useful_helicopters], SpeedyDex [speedydex] ]

Additional context

this seems to be another instance of items in fixed spawns not having any charges like in a previous report of mine for inhalers

Comrade-Soupbeans commented 3 years ago

doh, just noticed the typo in the title

actual-nh commented 3 years ago

doh, just noticed the typo in the title

You can edit the title, BTW.

ActualDio commented 3 years ago

If this is true its not in the json tables for military bases, must be somewhere in the loot creation algorithm. I have no idea what to look at in there tho.

Comrade-Soupbeans commented 3 years ago

If this is true its not in the json tables for military bases, must be somewhere in the loot creation algorithm. I have no idea what to look at in there tho.

i know that this was also an issue with the inhalers in fixed spawns, i reported that and it was fixed by https://github.com/CleverRaven/Cataclysm-DDA/pull/46804, it looks like the fix was making a new item with full charges in supplies.json and then using that in the loot table for the military base, though i'd also want to check for other fixed spawns that need updating

hexagonrecursion commented 3 years ago

Could not reproduce I found 7 oxygen tanks and 5 emergency oxygen tanks in the military base medical facility and they all were partially full. However many of them were nearly empty (1-4 charges).

OS: Linux
- OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 33 (Thirty Three); Release: 33; Codename: ThirtyThree;
Game Version: 20b0c03 [64-bit]
Graphics Version: Tiles
Game Language: English [en]
Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Bionic Professions [package_bionic_professions] ]

Comrade-Soupbeans commented 3 years ago

just reproduced it again by starting an unmodded debug world on the most recent experimental

OS: Windows
- OS Version: 10.0 2004
Game Version: 308d1d2 [64-bit]
Graphics Version: Tiles
Game Language: System language []
Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food] ]

hexagonrecursion commented 3 years ago

Confirmed. I think I was looking in the wrong closet. I opened the vault behind the "Medical Storage Access" computer terminal and found 7 empty oxygen tanks

OS: Linux
- OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 33 (Thirty Three); Release: 33; Codename: ThirtyThree;
Game Version: af9a595 [64-bit]
Graphics Version: Tiles
Game Language: English [en]
Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Bionic Professions [package_bionic_professions], Graphical Overmap [Graphical_Overmap] ]

RenechCDDA commented 1 year ago

https://github.com/CleverRaven/Cataclysm-DDA/blob/593bafd772d0ae0d3efe94fd6fabc34adbf998c4/data/json/mapgen/military/mil_base/mil_base_z0.json#L1192