Hunting lodges are unfinished

[KittyTac]

Describe the bug

Hunting lodges are missing a basement, a second floor, and the roof.

Steps To Reproduce

1. Make a world.
2. Debug reveal overmap.
3. Find a hunting lodge and teleport to it.
4. Look around and see only the ground level is finished.

Expected behavior

For the lodge to not have half of it get sucked away into another dimension.

Screenshots

No response

Versions and configuration

• OS: Windows
  • OS Version: 10.0 1909
• Game Version: f40b533 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Bionic Professions [package_bionic_professions], Kittymod [kittymod], Tankmod: Revived [Tankmod_Revived], Tankmod: Revived - UndeadPeople Tileset [Tankmod_RevivedUDP], No Fungal Monsters [No_Fungi] ]

Additional context

Kittymod is my personal mod, it doesn't alter hunting lodges.

[Maleclypse]

That's weird, so when I debuged the lodge in as I couldn't find it on twelve overmaps the basement worked fine. Second floor was definitely having some issues in that it was the roof for the floor below.

[KittyTac]

The basement in mine was blocked off by walls. Maybe the mapgen is weird with it, dunno.

[GoLoT]

I had this happen too. In my case the second floor was missing completely (no floor) and the closed off room (with barred windows) was missing the outer wall (not the windows though) with items spawning where the wall should be instead of on the shelves inside the room.

[Maleclypse]

I had this happen too. In my case the second floor was missing completely (no floor) and the closed off room (with barred windows) was missing the outer wall (not the windows though) with items spawning where the wall should be instead of on the shelves inside the room.

I think that is from the version where nested mapgen was deleting any pre-existing terrain. Which should be fixed if you update.

[hexagonrecursion]

Either hunting lodges are very rare or they don't spawn at all. Removing existing: true allows a couple of them to spawn per overmap. https://github.com/CleverRaven/Cataclysm-DDA/blob/ed2f630d83ecdf6033cb457ac9525759b7c91dc3/data/json/overmap/overmap_special/specials.json#L263

[hexagonrecursion]

So far can not reproduce: I have explored half a dozen of naturally spawned hunting lodges and they all had a basement and a second floor.

• OS: Linux
  • OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 33 (Thirty Three); Release: 33; Codename: ThirtyThree;
• Game Version: ed2f630 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Bionic Professions [package_bionic_professions] ]

[KittyTac]

I had this happen too. In my case the second floor was missing completely (no floor) and the closed off room (with barred windows) was missing the outer wall (not the windows though) with items spawning where the wall should be instead of on the shelves inside the room.

I think that is from the version where nested mapgen was deleting any pre-existing terrain. Which should be fixed if you update.

Late, but I just found one in a recent experimental, still no roof. None of my mods affect generation of those structures either.

[Night-Pryanik]

Can't reproduce this either. Closing as unconfirmed. If this is still an issue, ping me, and I'll reopen.