Friendly NPCs go neutral on death

[Priapism69]

Describe the bug

When a character dies, all NPCs are listed at death, and made neutral. This happens even when the NPCs aren't "for" that character, but another character in the same world. Build 2021-08-03-0939

Steps To Reproduce

1. Create 2 characters in the same world.
2. Befriend an NPC on 1 character.
3. Kill/suicide the other character.
4. Remaining character no longer has NPC as an ally.

Expected behavior

NPCs should be tied to the character who recruited them, or NPCs should be tied to any or all characters in the world.

Screenshots

No response

Versions and configuration

• OS: [e.g. iOS 8 or Windows 10 or Ubuntu 18.04]
• Game Version: [from the main menu, e.g. 0.C-29938-g90f5268437]
• Graphics version: [Tiles or Terminal]
• Ingame language: [Arabic or Bulgarian or Chinese (Simplified) or Chinese (Traditional) or Dutch or Esperanto or French or German or Italian (Italy) or Japanese or Korean or Polish or Portuguese (Brazil) or Russian or Serbian or Spanish (Argentina) or Spanish (Spain) or Turkish]
• Mods loaded: [e.g.dda, boats, hacktheplanet, StatsThroughSkills]

Additional context

No response

[Priapism69]

Update, out of 6 friendly NPCs, 5 required a mission to be completed for them (mandatory like neutral NPCs). Maybe coincidence or not, The missions were Jabberywocky x 3 and Inhaler x 2. All 6 NPCs had to be recruited like normal after completing the mission. (For anyone looking at all my edits, the NPCs seemed to be back to normal because I had left them on guard when they bugged out so they back to guard, once they are spoken to again, that's when they have to be recruited.) Update 2, the one NPC with no mission, that had been set to guard before the bugging, is stuck in a permanent loop of guarding. If you him to follow, he says he will, then immediately go back to guarding.

[hexagonrecursion]

Can not reproduce. Please open the affected world, press escape, select "debug menu", select "info", select "generate game report". This should copy the information about the game version into the clipboard. Please post it here. Example:

• OS: Linux
  • OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 33 (Thirty Three); Release: 33; Codename: ThirtyThree;
• Game Version: 7fec2ef [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Bionic Professions [package_bionic_professions] ]

If you can reproduce this bug, please attach a save file in a state where killing one character will trigger the bug.

[Priapism69]

• OS: Windows
  • OS Version: 10.0 2009
• Game Version: 08378ce [64-bit]
• Graphics Version: Tiles
• Game Language: System language []
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Bionic Professions [package_bionic_professions], Aftershock [aftershock], Blaze Industries [blazeindustries], Stats Through Kills [stats_through_kills], Useful Helicopters [useful_helicopters], Stats Through Skills [StatsThroughSkills] ]

[Priapism69]

I have tried reproducing it. I am unable to. I had it happen on 2 different worlds when I suicided old characters to clean up the world of as many characters. I guess it has to do with both worlds being made before the release of 0.F.

[actual-nh]

I've marked this as P5 - Long-term as something to check with the next migration validations.

[Priapism69]

I was able to get a save in the exact spot where if you kill one character, another character's NPCs go neutral. I don't know what save file you would need. I tried to attach the folder with the saved world, but it wouldn't allow me. I've only messed with the whole folders not individual files before, so which ones do you need? Is it master.gsav or is it something else?

[hexagonrecursion]

Zip the whole save folder up, upload it somewhere and post a link.

[Priapism69]

https://drive.google.com/file/d/1yj0NkeafAotbLYsZ8HvAIBNYdhhckAnp/view?usp=sharing Killed Doomed and Rick's NPCs go neutral. (the 5 in a line below him, the sixth one is the bugged one stuck guarding)

[hexagonrecursion]

Confirmed using the above save file

• OS: Linux
  • OS Version: LSB Version: :core-4.1-amd64:core-4.1-noarch; Distributor ID: Fedora; Description: Fedora release 33 (Thirty Three); Release: 33; Codename: ThirtyThree;
• Game Version: cb86201 [64-bit]
• Graphics Version: Tiles
• Game Language: English [en]
• Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Bionic Professions [package_bionic_professions], Aftershock [aftershock], Blaze Industries [blazeindustries], Stats Through Kills [stats_through_kills], No name () [], Stats Through Skills [StatsThroughSkills] ]

"No name" is because I don't have useful_helicopters