CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.66k stars 4.18k forks source link

Favorited liquids prevent reloading of partially full container #51278

Open MrHrulgin opened 3 years ago

MrHrulgin commented 3 years ago

Describe the bug

I have a bottle of antiseptic that I keep on me. Once I've used up some of the antiseptic, I reload it from the gallon jug I keep in my car. This is great.

I favorite the bottle and the liquid both. I then try to reload it. It says I'm reloading, but doesn't actually do so, nor does it take antiseptic from the gallon jug, it just silently fails.

Steps To Reproduce

  1. Favorite a liquid and the partially full container it's in.
  2. Try to reload it from another liquid source.
  3. See it fail to add liquid.

Expected behavior

I would expect that the container would fill, and the new liquid would be added to the favorited liquid "item".

Because I favorite things I want to keep, it's better to have the new liquid added to the favorite, as opposed to being unfavorited and in the same bottle, or having the whole volume be unfavorited.

Screenshots

No response

Versions and configuration

Additional context

No response

RoyBerube commented 3 years ago

Same behavior happens with favorite magazines and ammo. Annoying but not game breaking.

wapcaplet commented 2 years ago

Maybe related to #48120

Night-Pryanik commented 2 years ago

The bug still exists on 0.F-11128, but at least it doesn't fail silently anymore when I tried to reload my jerrycan with favorited salt water with non-favorited salt water: изображение