CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.63k stars 4.18k forks source link

Ambient sound stacking #52515

Closed HalfRetro closed 1 year ago

HalfRetro commented 3 years ago

Describe the bug

Issue with all sound packs with ambient sounds. Ambient sounds such as Indoor, outdoor, and/or underground sounds are stacking when prompted, and stay toggled on whether I'm indoors or out. Max stack I discovered so far is 2 ambient sound loops. Also the options menu for adjusting ambient sound levels is not making any affect to the ambience volume. The only way to untoggle, e.g., indoor.ogg and daytime.ogg, is by going underground, (or waiting for nighttime.ogg, which ends up stacking with indoors.ogg anyway) but upon resurfacing the underground.ogg continues to play with daytime.ogg (underground.ogg doesn't seem to stack with indoors.ogg when using a mineshaft elevator to transfer between the two environments) until entering an indoor environment tile, then they both toggle off and it plays indoors ambient sound, until going back outdoors and it all repeats again. Upon further testing, entering underground does not cause a stack with any above ground ambience, only upon exiting underground into outdoors, it stacks with the outdoor ambience.

Steps To Reproduce

  1. Load in character that is indoors during daytime
  2. prompt indoors.ogg by walking around indoors
  3. step outside and prompt daytime.ogg to start playing causing a sound stack of the both
  4. enter an underground area such as a sewer or mineshaft, through a manhole, to prompt underground.ogg and untoggle the previous stack
  5. exit underground, back through manhole, causing another sound stack with underground.ogg and daytime.ogg
  6. step into indoors environment tile, while underground.ogg and daytime.ogg are stacking, and toggle them both off when prompting indoors.ogg

Expected behavior

I expect every time I step into a new environment such as outdoors to indoors, that the ambient sound changes to the corresponding environment and untoggles the previous ambient sound loop. Only one ambient sound loop should be active per environment.

Screenshots

No response

Versions and configuration

Additional context

No response

kevingranade commented 2 years ago

This issue has been mentioned on Cataclysm: Dark Days Ahead. There might be relevant details there:

https://discourse.cataclysmdda.org/t/0-f-frank-release-is-here/26581/25

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not \'bump\' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.