CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.61k stars 4.17k forks source link

Character height should affect the rate of stamina consumption, or be entirely divorced from stamina #52982

Open alex-p-b opened 2 years ago

alex-p-b commented 2 years ago

Is your feature request related to a problem? Please describe.

Currently, character height affects maximum stamina. A huge character with the maximum height allowed by chargen has roughly double the stamina of a tiny character with the minimum allowed chargen height. I realize that this is probably a byproduct of #44370, because height affects BMR which in turn currently affects your cardio. Although increased size would certainly help you swing large, heavy things more easily, what about running or swinging very light objects, both of which are also governed by stamina? The ease with which large people swing large weapons is assuming size is proportionate to the amount of force you can exert, but would a large and small character of equal strength be able to swing large weapons with equal ease? What about a large character with low strength and a small character with high strength? And so on.

Describe the solution you'd like

I believe the simplest solution would be to multiply stamina consumption by a formula involving the ratio of your current height to average height (175 cm/5'9"). I would suggest a formula, but I'm no good at balancing. Deft would probably need to be looked at as I believe it reduces stamina cost of melee attacks by a flat amount, and thus would affect smaller characters disproportionately more than larger characters.

Describe alternatives you've considered

Have character height be entirely divorced from maximum stamina until a more comprehensive fix can be developed.

Additional context

Add any other context (such as mock-ups, proof of concepts or screenshots) about the feature request here.

anoobindisguise commented 2 years ago

Related issue - being morbidly obese lowers your health but also greatly increases your BMR, so extremely fat survivors (especially with Leukocyte Breeder) are actually better at endurance and exertion than their normal-weight counterparts which is kind of silly.

alex-p-b commented 2 years ago

Related issue - being morbidly obese lowers your health but also greatly increases your BMR, so extremely fat survivors (especially with Leukocyte Breeder) are actually better at endurance and exertion than their normal-weight counterparts which is kind of silly.

In that case, would a more correct solution be to have stamina consumption affected by a ratio of your BMI to average BMI? But then couldn't you just become skeletal to abuse that? I can't think of a reasonable solution.

I-am-Erk commented 2 years ago

The correct solution is to normalize your cardio score to your height and weight. The same thing should be done for fast metabolism and other things that alter your BMR but shouldn't affect your cardio. It should be a pretty easy math fix, a few lines of code IIRC.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not \'bump\' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

Maleclypse commented 2 years ago

Adding bug to prevent stalebot

I-am-Erk commented 2 years ago

Also needs to be resolved for #37446 - should be very easy, I will try to look at the math today.

TieSKey commented 2 years ago

Mmmmmm sorry if I'm just being contrarian or simply lack a lot of context on future roadmaps but given we have rpg attributes (str, dex, etc), having other "permanent" chargen values altering such an important thing as stamina doesn't add to a good game experience. Especially when the interaction between height/weight and stamina is not explained during chargen.

Translating, as a game, it would be a lot clearer to just use str and leave height/age as something purely aesthetic.

Otherwise, str should be changed to something like "muscle mass" and clearly grouped up with height and age in chargen, explaining their combined effect in stamina. Although I still think it is a better game experience to divorce unchangeable physical appearance from game mechanics so we don't get pluses or penalties from playing as someone in our own age/height range, etc.)

I-am-Erk commented 2 years ago

Stamina represents much more what we're going for in the future with attributes. At some point, strength may work similarly, and perception may become something more like a skill. However, the churn for such a change is more than anyone wants to take on right now.