Display a message when your lockpick is not good enough to pick a door

[NetSysFire]

Describe the bug

If you have a rudimentary lockpick and try to pick a locked metal door, it says "There is nothing to lockpick nearby".

Steps to reproduce

n/a

Expected behavior

It should instead say that you need a better lockpick to pick that metal door.

https://github.com/CleverRaven/Cataclysm-DDA/blob/7b60aa44723098c19dfad7353382cb75aff37dc5/src/activity_actor.cpp#L2381-L2389

Screenshots

No response

Versions and configuration

• experimental

Additional context

No response

[dseguin]

I tested this and I think there may be some confusion.

There are 2 version of the "closed metal door" terrain: t_door_metal_pickable and t_door_metal_locked. One has the PICKABLE flag, the other does not.

After spawning both versions of the locked door, the rudimentary lockpick works on the pickable door:

Also, looking at the in-game descriptions for both versions, the distinction is intentional:

Ultimately I was able to pick the locked metal door with the rudimentary lockpick.

[LeahLuong]

Perhaps there should be a more descriptive text for unpickable metal doors. I found this confusing once I discovered some of them can be picked. I thought it had to do w/ whether or not a building plan had been created in a more recent version of the game or maybe my char had simply gained enough skill to do it.

[NetSysFire]

Hmm. The specific terrain I got is:

https://github.com/CleverRaven/Cataclysm-DDA/blob/1b61a64a78686566108e365cf1b6fd1ac4d9eb93/data/json/mapgen/house/house23.json#L142-L189

which has a t_door_metal_locked. I have the lockpicking proficiency but not the locksmith one and get the message that there is nothing to lockpick nearby.

[NetSysFire]

I think the right thing to do here is to say that you can not find any keyholes in the type of metal door you can not pick and potentially swap the metal door in house23 to the type you can pick.

[pcdms-rygonia]

hi just to add that a post office building can have some safes (or jewellery safes), but when trying to lockpick them nothing happens... (i was able to use a pickaxe on them) but maybe if we simply needed more lockpicking skills, the message log could help indicate this too?

[LeahLuong]

@pcdms-rygonia You need a stethoscope to crack non-electronic safes.

[stale[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not \'bump\' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.

[NetSysFire]

Hmm, actually this may be a partial duplicate of #47069

[github-actions[bot]]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not bump or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.