CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.14k stars 4.11k forks source link

Rubiks 'help me install CBMs' option has some trade-based oddities #54211

Closed JantDarvus closed 1 year ago

JantDarvus commented 2 years ago

Describe the bug

If you ask Rubiks for help installing a CBM, he'll let you pick one of the ones he has physically lying around his shop without having to actually buy them first, only paying the installation fee. Additionally, if you ask him for help installing a CBM (any CBM, not just his own), choose what you'll give him to pay for it, but then choose 'No' when you see the prompt for failure chance, the trade made will still stand even though you've cancelled the process.

Steps to reproduce

Have a chat with Rubiks about installing CBMs. Either use one of his, free of charge-ish, or cancel a trade and notice he has a 'no backsies' policy.

Expected behavior

You should not be able to use any CBM that's considered to be in his shop inventory, nor should cancelling at the last moment result in the trade made to pay for it still standing.

Screenshots

No response

Versions and configuration

Additional context

No response

Maleclypse commented 2 years ago

Confirmed on discord.

Bossrman commented 2 years ago

You can also pay to install a cbm that you found elsewhere, and sell the cbm to him to pay for the installation of it.

RenechCDDA commented 1 year ago

Resolved at some point, as of https://github.com/CleverRaven/Cataclysm-DDA/commit/c94dc0387513d5bba49eb7d74b2b51a7a4d8c4a0

image

image