CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.62k stars 4.17k forks source link

Liquid containers auto-filling with random items #54332

Closed coyo7e closed 1 year ago

coyo7e commented 2 years ago

Describe the bug

Noticed this morning that I am having a ton of containers just filling up with no warning, including liquid containers. 11 items in a condom?! I even picked up a water tank and deconstructed something nearby and ended up with a 60L tank full of random junk.

Steps to reproduce

  1. pick up empty liquid container.
  2. pick up items (or insert them manually into container).
  3. observe liquid container full of items.

Expected behavior

Expect (sealable) liquid containers to only hold liquids - no logical reason to be able to fill a condom or water tank with hammers and wrenches and pipe fittings, although buckets and clay pots etc makes sense.

Screenshots

image

Versions and configuration

Additional context

No response

Terrorforge commented 2 years ago

There is a good reason to be able to put arbitrary items in condoms and other watertight containers - waterproofing. You can protect pills and electronics from damage that way.

But yes, I agree the "best pocket" algorithm seems a bit overenthusiastic about using containers-in-containers. In the mean time, I believe you can set a pocket to not autofill with any items by selecting it in the inventory and going to the autopickup settings

coyo7e commented 2 years ago

Unfortunately since it seems to prioritize any container in inventory, your workaround means having to manually go in and muss with autofill settings for every piece of clothing and container I might pick up.

Edit: just stuck a cowboy hat into a jerrycan.

tinukedaya commented 2 years ago

It's not just liquid containers. I have a first aid kit box in my Duffel bag. And even if the first aid box has priority for the pocket set to 0 and the duffel bag has 1000, if I pick up stuff e.g. rocks, some compression shorts, brass catcher and similar, it goes straight into the first aid box and not to the duffel bag. If it would go into the box once there is no empty space anywhere else I would (partially) understand that. But like this, ignoring the set priority I consider that a bug.

It's very annoying as I have drugs and stuff in the first aid box and have the contents hidden, because I don't want the clutter in my inventory. But that means, that if something else goes into the box, I can't see it and I usually forget it's there and carry the additional weight around . :/

And making workaround with whitelist for every single container I find is plain nuts. I just want all the stuff to go straight into the pockets based on priority if possible. And I don't see a valid reason, why rock or shorts, can't go directly into the main duffel bag pocket.

stale[bot] commented 2 years ago

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. Please do not \'bump\' or comment on this issue unless you are actively working on it. Stale issues, and stale issues that are closed are still considered.