CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.61k stars 4.17k forks source link

[Magiclysm] Wolfshead Cufflinks changes stats permanently #54343

Open Savengrr opened 2 years ago

Savengrr commented 2 years ago

Describe the bug

The activation of Wolfshead cufflinks changes the Strength stat by +2 and intelligence stat by -3 after the werewolf aura wears off.

Steps to reproduce

  1. Acquire "pair of wolfshead cufflinks"
  2. wear and activate the cufflinks
  3. Wait for aura to wear off
  4. Note permanent change in stats

Expected behavior

I expected the aura to only change the stats temporarily, but after waiting out the duration, some stat changes became permanent.

Screenshots

image image image

Versions and configuration

Additional context

I already have a probable cause, The aura_werewolf is the only item so far that seems to give the player temporary mutations with inherent changes to stats (Apex Predator[PRED4], Large[LARGE_OK]), the mutations seem to align with the permanent stat changes and I assume it doesn't return the stats when the mutations are removed.

If I'm correct than I'm not real certain of a good fix besides removing those mutations from what is given.

LeahLuong commented 2 years ago

If the temp mutations make stat changes, shouldn't they reapply when activating the cufflinks again?? Can you test if you are able to keep gaining Strength & losing Intelligence thru subsequent activations??

I wonder if this is related to #53111 in any way . . .

Savengrr commented 2 years ago

It is a repeatable process, you continue to gain strength and lose int. I tried it earlier for amusement

Sabbington commented 2 years ago

This still seems to be an issue--could one solution be adding a Trait, let's call it 'Lycanthrope' that is added when the aura wears off that adjusts your stats to compensate, is removed when the ring is activated again, repeat with each use?

Alternatively if it's possible to reuse spell components (or returning it to your inventory upon aura expiration) there might be an option of turning shapeshifting into a spell with the cufflinks as a component instead and bake the permanent compensatory stat adjustment into the spell effect?

Sabbington commented 2 years ago

It is a repeatable process, you continue to gain strength and lose int. I tried it earlier for amusement

After checking on the discord KorGgenT he seemed to expect the stats to revert to normal after the aura wears off, and after some additional testing I can't seem to duplicate the bug across existing or fresh characters--the stats are returning to their initial values. Can you share how you were getting the compounding permanent stat changes?

Savengrr commented 2 years ago

I can't reach the version I was on at the time anymore, but I can't seem to repeat it under the same conditions anymore either. I at the time could repeat it on a character with no mutations prior and base 8 stats on all, and on a character in another save that had some mutations but not "Large" or "Apex Predator"

Originally how it would seem to work for me; When you use the wolf cufflinks you see the base stats change in the parenthesis due to mutations that change said stats When the effects of the aura wore off and the mutations were removed the stat changes would persist.

It really didn't require anything else for me to do besides that.