CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.33k stars 4.14k forks source link

I don't know what to say for TALK_FREE_MERCHANTS_MERCHANT_Merch #54443

Closed hexagonrecursion closed 2 years ago

hexagonrecursion commented 2 years ago

Describe the bug

I got the following error when talking to a refugee center merchant:

 DEBUG    : I don't know what to say for TALK_FREE_MERCHANTS_MERCHANT_Merch. (BUG (npctalk.cpp:dynamic_line))

 FUNCTION : std::__cxx11::string dialogue::dynamic_line(const talk_topic&) const
 FILE     : src/npctalk.cpp
 LINE     : 1127
 VERSION  : 28c767d

Steps to reproduce

  1. Talk to the merchant
  2. Buy some merch
  3. "I wanted to talk"
  4. What's with these 'free merchant certified notes'?
  5. Get the above assertion

Expected behavior

No debug assertion

Screenshots

No response

Versions and configuration

Additional context

No response

PatrikLundell commented 2 years ago

I think line 121 of data/json/npcs/refugee_center/surface_staff/Smokes/free_merchant_shopkeep_talk.json should have a topic of TALK_FREE_MERCHANTS_MERCHANT_AboutMerch rather than TALK_FREE_MERCHANTS_MERCHANT_Merch.