CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.61k stars 4.17k forks source link

Pretty Badly Deformed #54602

Open LeahLuong opened 2 years ago

LeahLuong commented 2 years ago

Describe the bug

My Grotesque mutation forked into both Pretty & Badly Deformed after using some mutagenic serum, among other mutations. There were separate sentences for each mutation, 1 after another:

"Your Grotesque mutation has turned into Badly Deformed. Your Grotesque mutation has turned into Pretty."

Now, my char has both but I believe they're supposed to be mutually exclusive. 1 thing to note: my char started w/ Pretty as a trait & 1 of the 1st mutations canceled it w/ Ugly.

Steps to reproduce

IDK how to reproduce this. My best guess would be to use a char w/ starting trait Pretty, debug Grotesque, & inject mutagenic serum until you get lucky.

I think it might be more productive if some1 who is familiar w/ these sorts of issues did a code dive. Somehow, the interaction betw/ starting traits which can also be mutations & their mutation counterparts is not being respected. It may only be related to Pretty but I've a gut feeling it may be broader.

Expected behavior

I expected that Grotesque level would increase, because all other skills can increase in level.

Screenshots

No response

Versions and configuration

Android 0.F-3 Tiles English vanilla

Additional context

No response

Maleclypse commented 2 years ago

"I expected that Grotesque level would increase, because all other skills can increase in level." I'm confused by what you mean by this. Grotesque is not a skill and many traits have final evolution's.

LeahLuong commented 2 years ago

@Maleclypse It's a jest. The expected behavior should be obvious from the previous sections: mutually exclusive mutations shouldn't coexist on the same char.

Since posting, I've done a few more serums. "Your Badly Deformed mutation turned into Grotesque! Your innate Pretty trait turned into Grotesque!" was followed by, "Your Grotesque mutation turned into Badly Deformed. Your Grotesque mutation turned into Pretty," in the same mutation cycle. Was (un)lucky enough to pick up Smelly & Troglobite in the exact same dose (despite Robust Genetics) so it appears forking Grotesque only counts as a single mutation (as well as recombining it).

hexagonrecursion commented 2 years ago

Please post a screenshot of your @ screen with both traits. Please upload your save file.

LeahLuong commented 2 years ago

Bart 'Blizzard' Kimball _2022-01-21_22-00-08_+0000

So, I tried uploading a .zip of my game but got "is not included in the list" despite being just under 41 MB. Tried changing the suffix to .txt for the same thing.

I've uploaded a screenshot I took from the debug menu but I don't think you can make out how Pretty & Badly Deformed my char is. Couldn't figure out how to take a screenshot w/out 1st closing my char sheet. Keep in mind I'm doing all this from my phone so may not have the capability of generating a screenshot. Please let me know if you have any other ideas.

hexagonrecursion commented 2 years ago

You could upload your save to a file sharing service and post a link.

Hot to take a screenshot or record your screen on your Android device

LeahLuong commented 2 years ago

Screenshot_20220121-200128 Screenshot_20220121-200147

Alright, my traits list only shows 2 @ a time so I had to post 2 pics because there are too many traits in betw/ the 2 you've requested.

Here's a link to a .zip of my game shared on Google Drive: https://drive.google.com/file/d/1fJM6siWK-wrZiEItjoPVL_KLqKRohcdb/view?usp=drivesdk

If you scroll the message log up, near the cutoff you should find the messages I talked about earlier in this thread. Let me know if this isn't working for some reason.

By the way, thanks for the tip on screen capping.

LeahLuong commented 2 years ago

@hexagonrecursion I hope you haven't forgotten to loop back to this 1.

LeahLuong commented 2 years ago

Message log after a few more serums:

Screenshot_20220209-150917

Confirmation tag, please!

LeahLuong commented 2 years ago

The fix for this is likely the same as #55237. This same issue may crop up w/ any starting trait that should be canceled by a mutation.