CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.26k stars 4.12k forks source link

Some recipes can be made without meat but are still considered to be meat #54795

Open JantDarvus opened 2 years ago

JantDarvus commented 2 years ago

Describe the bug

Some recipes have the option to use non-meat ingredients instead of meat ingredients, such as Deluxe Beans And Rice, but these recipes will still list as having 'Flesh' even if no flesh is involved, which is an issue for traits like Meat Intolerance.

Steps to reproduce

  1. Get your hands on beans, rice, eggs, salt and clean water.
  2. Craft deluxe beans and rice.
  3. See the 'Flesh' material still being involved.

Expected behavior

A food with no Flesh material in the creation of it should not have the Flesh material in the end product.

Screenshots

image

Versions and configuration

Additional context

No response

moxian commented 2 years ago

related: https://github.com/CleverRaven/Cataclysm-DDA/issues/52226 https://github.com/CleverRaven/Cataclysm-DDA/issues/48489

LeahLuong commented 2 years ago

Eggs are a dairy item & considered non-vegan IRL. Many vegetarians IRL refrain from eating eggs. While I agree coconut milk prob shouldn't be classified as dairy, I personally see no issue w/ eggs conferring the flesh tag.

@JantDarvus It would be helpful if you started compiling a list of problematic recipes pertaining to this issue in the "Additional Context" section. For example, deluxe beans & rice using tofu gaining the flesh tag (if that's a thing).

To whomever takes these issues on, please keep in mind how the recipe flags pertain to achievements.

Alex-Folts commented 2 years ago

The thing is the list of materials defined by item itself, and it is static: https://github.com/CleverRaven/Cataclysm-DDA/blob/ae582e071e8660f82aef858a14a9dc5d1190d293/data/json/items/comestibles/meat_dishes.json#L899

So need to add new item which dont have flesh material, and new recipe for it which dont use meat.

Or implement complex system which will define materials dynamically based on used craft components. This is good solution for future.

coyo7e commented 2 years ago

Eggs are a dairy item & considered non-vegan IRL. Many vegetarians IRL refrain from eating eggs.

This is untrue. Lacto-ovo an/or ovo vegetarians are very common because they do not see eating animal products the same as eating animal flesh. Should pescatarians also be lumped in with them?

LeahLuong commented 2 years ago

@Alex-Folts Cooking recipes inherit calories from ingredients. I thought they inherited flags from ingredients as well. This prob means my deluxe beans & rice using tofu example is a thing (i.e., contains flesh).

@coyo7e Vegan ≠ vegetarian. Fish meat = meat. See #47811.