Unfound mutation vitamin ids

catdach commented 2 years ago

Describe the bug

taking mutagen causes error messages saying that vitamins with certain id's don't exist; specifically: "mutagen_snail" and "mutagen_trog"(frog?).

Steps to reproduce

take any type of mutagen/mutagenic primers.
pass at least an hour of time.
error pops up

Expected behavior

errors not occurring.

Screenshots

Versions and configuration

OS: Windows
- OS Version: 10.0.19043.1526 (21H1)
Game Version: 6cea46d [64-bit]
Graphics Version: Tiles
Game Language: English [en]
Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], Bionic Professions [package_bionic_professions], Graphical Overmap [Graphical_Overmap], Stats Through Skills [StatsThroughSkills], Stats Through Kills [stats_through_kills], Mythical Martial Arts [MMA], SpeedyDex [speedydex], Magiclysm [magiclysm], Graphical Overmap Magiclysm [Graphical_Overmap_Magiclysm], C.R.I.T Expansion Mod [crt_expansion], Blaze Industries [blazeindustries] ]

Additional context

No response

MylieDaniels commented 2 years ago

Let me check some things on this, I believe the issue is appearing for saves that had Snail or Trog mutagen in their bloodstream between Venera3's implementation of them and my PR that renamed them to Gastropod and Troglobite mutagen internally- honestly a foolish decision driven by an excessive desire for "consistency" amongst the categories, and I'll tackle a solution.

Maleclypse commented 2 years ago

Let me check some things on this, I believe the issue is appearing for saves that had Snail or Trog mutagen in their bloodstream between Venera3's implementation of them and my PR that renamed them to Gastropod and Troglobite mutagen internally- honestly a foolish decision driven by an excessive desire for "consistency" amongst the categories, and I'll tackle a solution.

Oh yeah, changing things for consistency almost always causes some heavy workload to fix the ensuing errors. Good lesson to learn early. And it makes git_blame more difficult.

MylieDaniels commented 2 years ago

I'll be real, since Venera3 only added the ones they needed for limbs and I added some as well, I mistakenly assumed that these two were only in my branch, and assumed I could rename them freely since no-one would have them yet. I suppose Snail was in to prepare for growing shells, and... not sure what Venera is planning to do with Troglobite limbs, but I'm sure it will be cool!

bombasticSlacks commented 2 years ago

To add to this my character is also getting these errors and they are straightedge and haven't ingested any mutagen.

Sathra225 commented 2 years ago

Had this after first ever dose of mutagen for this char. After the vitamin-mutagen change. The invalid vitamins were still listed in the savefile under 'stomach' and 'guts'. Removing those fixed the problem.

MylieDaniels commented 2 years ago

Thank you both, that helps me narrow down where to place a check for and clear non-existent vitamins. Have an ear infection currently, apologies for not getting this fixed sooner.

MylieDaniels commented 2 years ago

After a short discussion with Kevin, this issue will be tackled in a relatively unique fashion, for the following reasons:

This issue only affects saves that were played during a brief, approximately 2 week period of experimental builds.
This issue does not harm gameplay, and the only effect is an uncommon debug message.
Any fix for this issue would either introduce unneeded special-case code or obscure other issues of the same message.

As such, Sathra225's method is the recommended course of action:

Had this after first ever dose of mutagen for this char. After the vitamin-mutagen change. The invalid vitamins were still listed in the savefile under 'stomach' and 'guts'. Removing those fixed the problem.

If you created or played a character in an experimental build between the introduction of the initial mutagen vitamins by Venera3 and the mutagen changes by me, you will be facing this issue. To fix it, remove the invalid vitamins (mutagen_snail and mutagen_trog) from your savefile's stomach and guts. I apologize that this issue arose, and hope that players will understand that it was a mistake on my part and that such is the nature of Experimental.

If anyone has a question about how to safely edit their savefile to fix this, or wants me to do it for them and can send me the savefile, please ping me.

Requesting this issue remain open for a week or two, to direct users to me for aid in fixing any problems they may have.

alXDraghiciu commented 2 years ago

After a short discussion with Kevin, this issue will be tackled in a relatively unique fashion, for the following reasons:

This issue only affects saves that were played during a brief, approximately 2 week period of experimental builds.

This issue does not harm gameplay, and the only effect is an uncommon debug message.

Any fix for this issue would either introduce unneeded special-case code or obscure other issues of the same message.

As such, Sathra225's method is the recommended course of action:

Had this after first ever dose of mutagen for this char. After the vitamin-mutagen change. The invalid vitamins were still listed in the savefile under 'stomach' and 'guts'. Removing those fixed the problem.

If you created or played a character in an experimental build between the introduction of the initial mutagen vitamins by Venera3 and the mutagen changes by me, you will be facing this issue. To fix it, remove the invalid vitamins (mutagen_snail and mutagen_trog) from your savefile's stomach and guts. I apologize that this issue arose, and hope that players will understand that it was a mistake on my part and that such is the nature of Experimental.

If anyone has a question about how to safely edit their savefile to fix this, or wants me to do it for them and can send me the savefile, please ping me.

Requesting this issue remain open for a week or two, to direct users to me for aid in fixing any problems they may have.

Hi. I'm also having this issue. Where can I find the stomach and guts stuff in my save?

MylieDaniels commented 2 years ago

The relevant save file is under [Cataclysm folder]/save/[WorldName]/ There will be a bunch of files, one of which is a random mash of characters in the format .sav You want to remove all references to "mutation_trog" and "mutation_snail". I advise making a backup copy of the file beforehand, and if you do not feel confident doing this, please post that file and I will do it for you. Again, sorry about the inconvenience.

alXDraghiciu commented 2 years ago

Thanks a lot. No problem glad you could help me solve it.

TadhgEomonn commented 2 years ago

I am also getting these error messages. However, my .sav file has neither "mutation_trog" or"mutation_snail" references. So, editing out the problem is not possible for me.

I am experiencing these errors (both trog and snail versions, one after the other) while reading skill books: both vanilla CDDA skill books and Magiclysm and Arcana scrolls and books.

MylieDaniels commented 2 years ago

Are there multiple .sav files in your folder? It is possible you are looking at a different character. In addition, if you are searching for "mutation_trog" and "mutation_snail", please note that it is "mutagen_trog" and "mutagen_snail", instead. If you are still experiencing this issue after checking each .sav file for those two terms, please let me know so I can figure out how to help!

TadhgEomonn commented 2 years ago

I have only one .sav file.

My search for "mutation_trog" and "mutation_snail" found zero occurrences, but I do have both "mutagen_trog" and "mutagen_snail" entries. So I was looking for the wrong things. Good catch.

To be clear, for an occurrence, such as this: "mutagen_trog": 0 I should erase it and the preceding comma from the file?

MylieDaniels commented 2 years ago

I'm glad I was able to help. That's correct, though I recommend making a backup of that file first just in case you typo or something.

TadhgEomonn commented 2 years ago

Thank you, MylieDaniels.

CleverRaven / Cataclysm-DDA