Tacoma farm map error report (flags...)

PatrikLundell commented 2 years ago

Describe the bug

DEBUG : In nested mapgen tacoma_commune_junk_shop_13 in unknown object in add_mapgen_update_func on ranch_camp_49_north, setting terrain to t_dirtfloor (from t_dirt) at (2,12) when item feces_manure existed. Resolve this either by removing the terrain from this mapgen, adding suitable removal commands to the mapgen, or by adding a suitable flag to the innermost mapgen: either ERASE_ALL_BEFORE_PLACING_TERRAIN if you wish terrain to replace everything previously on the tile or ALLOW_TERRAIN_UNDER_OTHER_DATA if you wish the other items to be preserved

FUNCTION : apply FILE : D:\a\Cataclysm-DDA\Cataclysm-DDA\src\mapgen.cpp LINE : 2612 VERSION : 30c8dc3

Steps to reproduce

Hand in the radio quest at the Tacoma farm.
Get the message when the map is modified.

Expected behavior

No error report.

Screenshots

No response

Versions and configuration

OS: Windows
- OS Version: 10.0.19043.1645 (21H1)
Game Version: 30c8dc3 [64-bit]
Graphics Version: Tiles
Game Language: System language []
Mods loaded: [ Dark Days Ahead [dda], Disable NPC Needs [no_npc_food], No Fungal Growth [no_fungal_growth], Bionic Professions [package_bionic_professions] ]
JSON addition of wind mill recipe to workshop 2 blacksmith
JSON "mod" to disable portal storms as the PR mod providing that was rejected.

Additional context

I'd recommend the ALLOW_... flag, as the player may potentially (and stupidly) place stuff in that location.

haveric commented 2 years ago

I'll probably add the allow to everything in the Tacoma updates. I was hoping to be able to move some of them to different locations, but I don't think that has been implemented yet.

SamGondra commented 1 week ago

this is something that happens (still) in 0.H stable

 DEBUG    : In nested mapgen tacoma_commune_clinic_10_1 in unknown object in add_mapgen_update_func on ranch_camp_59_east, setting terrain to t_dirtfloor (from t_dirt) at (12,8) when furniture was f_thistle.  Resolve this either by removing the terrain from this mapgen, adding suitable removal commands to the mapgen, or by adding an appropriate clearing flag to the innermost layered mapgen.  Consult the "mapgen flags" section in MAPGEN.md for options.

 FUNCTION : virtual void jmapgen_terrain::apply(const mapgendata&, const jmapgen_int&, const jmapgen_int&, const string&) const
 FILE     : src/mapgen.cpp
 LINE     : 2972
 VERSION  : 78fd6e3

probably the case for most map gen on Tacoma (I had 3 similar errors)

CleverRaven / Cataclysm-DDA