search

CleverRaven / Cataclysm-DDA

Cataclysm - Dark Days Ahead. A turn-based survival game set in a post-apocalyptic world.
http://cataclysmdda.org
Other
10.63k stars 4.17k forks source link

Tin can of curry with meat spoils #5873

Closed Soyweiser closed 9 years ago

Soyweiser commented 10 years ago

Like terrible person said when I complained about it on IRC:

Soyweiser: That still happens? I complained about it a while ago... realistically speaking, properly canned food never goes bad (not in a lifetime, anyways). Tastiness might deteriorate, but you should never have spoilage. I agree. As long as you do not throw with the cans it should be allright Edit: http://smf.cataclysmdda.com/index.php?topic=5747.0 seems to be still around. --- Want to back this issue? **[Place a bounty on it!](https://www.bountysource.com/issues/1548769-tin-can-of-curry-with-meat-spoils?utm_campaign=plugin&utm_content=tracker%2F146201&utm_medium=issues&utm_source=github)** We accept bounties via [Bountysource](https://www.bountysource.com/?utm_campaign=plugin&utm_content=tracker%2F146201&utm_medium=issues&utm_source=github).
i2amroy commented 10 years ago

Yeah, fairly easy to fix, just a small JSON change.

Soyweiser commented 10 years ago

Don't know if it is that easy. It should spoil if you remove it from the tin cans. But not if you keep it in the cans. Not sure how that works.

i2amroy commented 10 years ago

Really canned foods should have two different "states", one in which they are opened and will spoil, and the other where they aren't. The problem now is that since there is only one state we are either forced to assume that all times a particular food appears it never spoils (regardless of container type) or that all cans are open and will spoil eventually.

KA101 commented 10 years ago

Basically, we need to make "can of X" work the same way as sealed plastic bags, jarred food, etc.

illi-kun commented 10 years ago

It's probably linked with #3596.

i2amroy commented 10 years ago

Basically, we need to make "can of X" work the same way as sealed plastic bags, jarred food, etc.

Pretty much.

kevingranade commented 10 years ago

I wouldn't object if someone were to make a "uncan" iuse and all that jazz, but the other thing I'd like to do is have a master iuse that handles transforming one item into another, and have the data for the transformation in the item definition. This would allow json only creation of canned and activatable items, and cut out a big chunk of redundant code from iuse.cpp The tricky bit is items with multiple actions and menus :/

KA101 commented 9 years ago

Think we nailed this one.